From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EC2D18622 for ; Sat, 7 Oct 2023 10:34:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JjhkLD7m" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA727C433C8; Sat, 7 Oct 2023 10:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696674845; bh=h8vx4z1MJn6Xg4V0FZ5iIw9Vqe+NhY8gHjO+UERrT0o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JjhkLD7m0SpMPLTTfVV3BHBL46xSgdqcJTOmzENTlQnrGS9yKxtbhtNrX/mgFGvNo KBR3Y4kFd3CObVJFSlScQbUOtQhqVArp1HkLLzFhx0MaPQsd7A4NB+x7dAZyUCP4yW cjflLW/xt83L6AKqikNKf+ErUNepmkSwc+JTqh6LmfcBKSUB4u5QV1J4BpMZaZ4cyT 6spPS+DR83q0lHfMY0fi5cWaMqXjkJzIhG84m5WCDnSdx54q9hLabk2NFRR8u6tH4P nv3B8FSf4gmhy7Vroz8LbrEeppFAsaNlCE2x8CRmPSJ5ecOxKE1RevmB/NqAQOFjUF 9ayTjREculhug== Date: Sat, 7 Oct 2023 11:34:01 +0100 From: Conor Dooley To: Keguang Zhang Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley Subject: Re: [PATCH v5 1/2] dt-bindings: dma: Add Loongson-1 DMA Message-ID: <20231007-untapped-masses-01f80b7c13c7@spud> References: <20230928121953.524608-1-keguang.zhang@gmail.com> <20230928121953.524608-2-keguang.zhang@gmail.com> <20230928-capacity-husked-305f03680834@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pkowK5kK8UfqjnMn" Content-Disposition: inline In-Reply-To: --pkowK5kK8UfqjnMn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 07, 2023 at 01:45:23PM +0800, Keguang Zhang wrote: > On Fri, Sep 29, 2023 at 12:42=E2=80=AFAM Conor Dooley = wrote: > > > > Hey, > > > > On Thu, Sep 28, 2023 at 08:19:52PM +0800, Keguang Zhang wrote: > > > Add devicetree binding document for Loongson-1 DMA. > > > > > > Signed-off-by: Keguang Zhang > > > --- > > > V4 -> V5: > > > A newly added patch > > > > > > .../bindings/dma/loongson,ls1x-dma.yaml | 64 +++++++++++++++++= ++ > > > 1 file changed, 64 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/dma/loongson,ls= 1x-dma.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/dma/loongson,ls1x-dma.= yaml b/Documentation/devicetree/bindings/dma/loongson,ls1x-dma.yaml > > > new file mode 100644 > > > index 000000000000..51b45d998a58 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/dma/loongson,ls1x-dma.yaml > > > @@ -0,0 +1,64 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/dma/loongson,ls1x-dma.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Loongson-1 DMA Controller > > > + > > > +maintainers: > > > + - Keguang Zhang > > > + > > > +description: | > > > > This | isn't required as you have no formatting to preserve here. > > > Will remove '|'. >=20 > > > + Loongson-1 DMA controller provides 3 independent channels for > > > + peripherals such as NAND and AC97. > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - loongson,ls1b-dma > > > + - loongson,ls1c-dma > > > > From a skim of the driver, these two devices seem to be compatible, > > and therefore one should fall back to the other. > > > Got it. How about changing to one const? > compatible: > const: loongson,ls1-dma No, keep the compatibles you have & set up a fallback please. Too many of these loongson bindings have got in with overly generic compatibles... --pkowK5kK8UfqjnMn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZSE0GQAKCRB4tDGHoIJi 0uTzAP93/jJpexiSebL/3MJDtEQmLCQQ/S1iMZzDwIVicXNBuAD/dC0GaspLD+/4 LvDML2oJxJpiYFJJhGSyyC0Pkj79iAQ= =3tOl -----END PGP SIGNATURE----- --pkowK5kK8UfqjnMn--