From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB11A79CD for ; Sat, 7 Oct 2023 06:44:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 42903D6; Fri, 6 Oct 2023 23:44:41 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id AD8CC80E0; Sat, 7 Oct 2023 06:44:40 +0000 (UTC) Date: Sat, 7 Oct 2023 09:44:39 +0300 From: Tony Lindgren To: "H. Nikolaus Schaller" Cc: Andreas Kemnade , bcousson@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: omap3-gta04: Drop superfluous omap36xx compatible Message-ID: <20231007064439.GN34982@atomide.com> References: <20231004065323.2408615-1-andreas@kemnade.info> <12323F42-3611-4685-8981-F6A18C4A5862@goldelico.com> <20231004130353.01228376@aktux> <20231004135449.591b3f6c@aktux> <42806B60-E48B-4AA9-B375-E9F65F59AB87@goldelico.com> <6B245439-F9FE-4931-A0DE-81F825BB5FE5@goldelico.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6B245439-F9FE-4931-A0DE-81F825BB5FE5@goldelico.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net * H. Nikolaus Schaller [231004 12:50]: > What about the PVR/SGX driver. This needs a compatible that can distinguish > between the DM3725 and DM3730. The first is w/o SGX and the second one > with. Having all summarized as omap3630 does not allow to load the > PVR/SGX driver based on the board specific compatible entry. > > AFAIR this was the original idea behind > > compatible = "goldelico,gta04", "ti,omap3630", "ti,omap36xx", "ti,omap3"; I think we already handle this, see drivers/bus/ti-sysc.c and search for DIS_SGX and similar flags for other accelerators. So I think this patch is safe to apply? Regards, Tony