devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Andreas Kemnade <andreas@kemnade.info>,
	bcousson@baylibre.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: omap3-gta04: Drop superfluous omap36xx compatible
Date: Sat, 7 Oct 2023 09:58:13 +0300	[thread overview]
Message-ID: <20231007065813.GR34982@atomide.com> (raw)
In-Reply-To: <6D2A2AA0-759A-4AF8-967A-ED6FE2F6C1BB@goldelico.com>

* H. Nikolaus Schaller <hns@goldelico.com> [231007 06:54]:
> Hi Tony,
> 
> > Am 07.10.2023 um 08:44 schrieb Tony Lindgren <tony@atomide.com>:
> > 
> > * H. Nikolaus Schaller <hns@goldelico.com> [231004 12:50]:
> >> What about the PVR/SGX driver. This needs a compatible that can distinguish
> >> between the DM3725 and DM3730. The first is w/o SGX and the second one
> >> with. Having all summarized as omap3630 does not allow to load the
> >> PVR/SGX driver based on the board specific compatible entry.
> >> 
> >> AFAIR this was the original idea behind 
> >> 
> >> 	compatible = "goldelico,gta04", "ti,omap3630", "ti,omap36xx", "ti,omap3"; 
> > 
> > I think we already handle this, see drivers/bus/ti-sysc.c and search for
> > DIS_SGX and similar flags for other accelerators.
> 
> Ah, ok. This means that the kernel module isn't loaded if the flags of the chip
> are not available. Then we will indeed have no need to describe such variances
> in the DTS.
> 
> > So I think this patch is
> > safe to apply?
> 
> Looks so (especially as I only have omap3630 based devices with SGX).

OK applying into omap-for-v6.7/dt then.

Thanks,

Tony

      reply	other threads:[~2023-10-07  6:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-04  6:53 [PATCH] ARM: dts: omap3-gta04: Drop superfluous omap36xx compatible Andreas Kemnade
2023-10-04 11:02 ` H. Nikolaus Schaller
     [not found] ` <12323F42-3611-4685-8981-F6A18C4A5862@goldelico.com>
2023-10-04 11:03   ` Andreas Kemnade
2023-10-04 11:39     ` H. Nikolaus Schaller
2023-10-04 11:54       ` Andreas Kemnade
2023-10-04 12:42         ` H. Nikolaus Schaller
2023-10-04 12:50           ` H. Nikolaus Schaller
2023-10-07  6:44             ` Tony Lindgren
2023-10-07  6:54               ` H. Nikolaus Schaller
2023-10-07  6:58                 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231007065813.GR34982@atomide.com \
    --to=tony@atomide.com \
    --cc=andreas@kemnade.info \
    --cc=bcousson@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hns@goldelico.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).