From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31D3B16401 for ; Mon, 9 Oct 2023 11:19:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="E9BikLWW" Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3D3C99; Mon, 9 Oct 2023 04:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1696850344; x=1728386344; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=J9XfCfLh3uUBpLPinWOH535XxsKH9kUB5wldTFik5pY=; b=E9BikLWWeFyudoC+2DVq/J+TaFPLJLd4/XslZbUiwm2jUP+UriKhXgEQ a0pbBCK2Og7h5UhDMT3dcUYeLMdTYiIi7ONpBubHlRtcQhXEJhtPO9Xs0 pbtYsdfLxv7+WLIcAdjy5J3HIv/cz6x2HiwmHAQ0NwA3ho7PExTj5gjhG buSU2GUVVfBRpKccvr/PC542cuBT/Jk28EFhpThhJgQB5gQ2Kjc6q2BWc NfSJgmjrEcpXYN6vJCGofL2+GtCUTfznChmPtROPV+e7BhmPKznhtX7VO yWMRIWo7wuOUjFBbCyeSBKUKZ0WPlBPTn6uXDvBA7VGlvVBaUhtr/FZZO g==; X-CSE-ConnectionGUID: NZ7vyGJUSvi3vJgcsAydsg== X-CSE-MsgGUID: wK/7D4VzS0GphfD8pkrksQ== X-ThreatScanner-Verdict: Negative X-IronPort-AV: E=Sophos;i="6.03,210,1694761200"; d="asc'?scan'208";a="9659116" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Oct 2023 04:16:55 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 9 Oct 2023 04:16:51 -0700 Received: from wendy (10.10.85.11) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Mon, 9 Oct 2023 04:16:48 -0700 Date: Mon, 9 Oct 2023 12:16:27 +0100 From: Conor Dooley To: Minda Chen CC: Daire McNamara , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Emil Renner Berthing , , , , , Paul Walmsley , "Palmer Dabbelt" , Albert Ou , "Philipp Zabel" , Mason Huo , Leyfoon Tan , Kevin Xie Subject: Re: [PATCH v7 0/19] Refactoring Microchip PCIe driver and add StarFive PCIe Message-ID: <20231009-matchless-confined-d0d0d3188f76@wendy> References: <20230927100802.46620-1-minda.chen@starfivetech.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1VqoUkWDs6YiGRyl" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net --1VqoUkWDs6YiGRyl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 09, 2023 at 06:58:42PM +0800, Minda Chen wrote: >=20 >=20 > On 2023/9/27 18:07, Minda Chen wrote: > > This patchset final purpose is add PCIe driver for StarFive JH7110 SoC. > > JH7110 using PLDA XpressRICH PCIe IP. Microchip PolarFire Using the > > same IP and have commit their codes, which are mixed with PLDA > > controller codes and Microchip platform codes. > >=20 > > For re-use the PLDA controller codes, I request refactoring microchip > > codes, move PLDA common codes to PLDA files. > > Desigware and Cadence is good example for refactoring codes. > >=20 > > So first step is extract the PLDA common codes from microchip, and > > refactoring the microchip codes.(patch1 - 16) > > Then, add Starfive codes. (patch17 - 19) > >=20 > > This patchset is base on v6.6-rc3 > >=20 > > patch1 is move PLDA XpressRICH PCIe host common properties dt-binding > > docs from microchip,pcie-host.yaml > > patch2 is move PolarFire codes to PLDA directory. > > patch3 is move PLDA IP register macros to plda-pcie.h > > patch4 is rename data structure in microchip codes. > > patch5 is rename two setup functions in microchip codes, prepare to move > > to common file. > > patch6 is change the arguments of plda_pcie_setup_iomems() > > patch7 is move the two setup functions to common file pcie-plda-host.c > > patch8 is Add PLDA event interrupt codes and IRQ domain ops. > > patch9 is rename the IRQ related functions, prepare to move to > > pcie-plda-host. > > patch10 - 14 is modify the event codes, preparing for support starfive > > and microchip two platforms. > > patch15 is move IRQ related functions to pcie-plda-host.c > > patch16 is set plda_event_handler to static. > > patch17 is add StarFive JH7110 PCIe dt-binding doc. > > patch18 is add StarFive JH7110 Soc PCIe codes. > > patch19 is Starfive dts config > >=20 > Hi Conor and Daire > Have you ever test this patchset=EF=BC=9F I'm sure I am not change logic= of the PolarFire PCIe driver, > But I can not test it. > Since this series patch is delegate to nobody and no response now. I don'= t know when this patch set can be accepted. I'll try to look at this series again this week. I've been AFK a bit with holidays etc recently, and been a bit delayed in general. I was mostly happy with it before, and had left reviewed-bys on most of the series I think. > I still hope the refactoring patches can be accepted first The last patchset Daire sent has been applied: https://lore.kernel.org/all/169149233963.79399.5232296870054239065.b4-ty@ke= rnel.org/ > (I know you want to add the function of inbound and outbound address tran= slation, Hope this series patch do not influence your upstream plan) I'd expect this series to go in before the inbound/outbound translation one, since this is a lot closer to ready & is being resent more often. Cheers, Conor. --1VqoUkWDs6YiGRyl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZSPhCwAKCRB4tDGHoIJi 0maLAQDzkRvnyxGPUhY4gLfqG7RjqaP+WSm0vTPY+S4QtyzXMAD/QLl+XDX+f8iN 8iCOQE83MPGAVCqa5pRd+mCx1i/2Gw4= =OAEx -----END PGP SIGNATURE----- --1VqoUkWDs6YiGRyl--