Re: [PATCH v7 11/19] PCI: microchip: Add request_event_irq() callback function

Conor Dooley
2023-10-09T13:45:49Z

[-- Attachment #1: Type: text/plain, Size: 3695 bytes --]

Hey,

On Wed, Sep 27, 2023 at 06:07:54PM +0800, Minda Chen wrote:
> PolarFire register 28 interrupts symbols name.
> PLDA just reguster 13 interrupts, it is not require to
> register symbol name. So add a callback functions
> to support StarFive and Microchip platforms.

I'm not really sure how the number of interrupts relates to whether or
not symbol names need to be registered.

The code itself (again) seems okay to me, but I think this commit
message doesn't really explain the rationale behind the patch to someone
who is not really familiar with the interrupt handling here.

Thanks,
Conor.

>
> Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
> ---
> .../pci/controller/plda/pcie-microchip-host.c | 25 ++++++++++++++++---
> drivers/pci/controller/plda/pcie-plda.h | 5 ++++
> 2 files changed, 26 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/controller/plda/pcie-microchip-host.c b/drivers/pci/controller/plda/pcie-microchip-host.c
> index d9dd63084e2b..e3c7d5e66150 100644
> --- a/drivers/pci/controller/plda/pcie-microchip-host.c
> +++ b/drivers/pci/controller/plda/pcie-microchip-host.c
> @@ -798,6 +798,17 @@ static int mc_pcie_init_clks(struct device *dev)
> return 0;
> }
>
> +static int mc_request_event_irq(struct plda_pcie_rp *plda, int event_irq,
> + int event)
> +{
> + return devm_request_irq(plda->dev, event_irq, mc_event_handler,
> + 0, event_cause[event].sym, plda);
> +}
> +
> +static const struct plda_event mc_event = {
> + .request_event_irq = mc_request_event_irq,
> +};
> +
> static int plda_pcie_init_irq_domains(struct plda_pcie_rp *port)
> {
> struct device *dev = port->dev;
> @@ -897,7 +908,9 @@ static void mc_disable_interrupts(struct mc_pcie *port)
> writel_relaxed(GENMASK(31, 0), bridge_base_addr + ISTATUS_HOST);
> }
>
> -static int plda_init_interrupts(struct platform_device *pdev, struct plda_pcie_rp *port)
> +static int plda_init_interrupts(struct platform_device *pdev,
> + struct plda_pcie_rp *port,
> + const struct plda_event *event)
> {
> struct device *dev = &pdev->dev;
> int irq;
> @@ -921,8 +934,12 @@ static int plda_init_interrupts(struct platform_device *pdev, struct plda_pcie_r
> return -ENXIO;
> }
>
> - ret = devm_request_irq(dev, event_irq, mc_event_handler,
> - 0, event_cause[i].sym, port);
> + if (event->request_event_irq)
> + ret = event->request_event_irq(port, event_irq, i);
> + else
> + ret = devm_request_irq(dev, event_irq, plda_event_handler,
> + 0, NULL, port);
> +
> if (ret) {
> dev_err(dev, "failed to request IRQ %d\n", event_irq);
> return ret;
> @@ -976,7 +993,7 @@ static int mc_platform_init(struct pci_config_window *cfg)
> return ret;
>
> /* Address translation is up; safe to enable interrupts */
> - ret = plda_init_interrupts(pdev, &port->plda);
> + ret = plda_init_interrupts(pdev, &port->plda, &mc_event);
> if (ret)
> return ret;
>
> diff --git a/drivers/pci/controller/plda/pcie-plda.h b/drivers/pci/controller/plda/pcie-plda.h
> index 5b09ffed623c..4e0712c9365e 100644
> --- a/drivers/pci/controller/plda/pcie-plda.h
> +++ b/drivers/pci/controller/plda/pcie-plda.h
> @@ -153,6 +153,11 @@ struct plda_pcie_rp {
> int num_events;
> };
>
> +struct plda_event {
> + int (*request_event_irq)(struct plda_pcie_rp *pcie,
> + int event_irq, int event);
> +};
> +
> irqreturn_t plda_event_handler(int irq, void *dev_id);
> void plda_pcie_setup_window(void __iomem *bridge_base_addr, u32 index,
> phys_addr_t axi_addr, phys_addr_t pci_addr,
> --
> 2.17.1
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]