From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6B8E27453 for ; Tue, 10 Oct 2023 15:35:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q8biabOl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4ED1BC433C9; Tue, 10 Oct 2023 15:35:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696952159; bh=GiaOPPDy4bW4X7nEWcj7MoZCeHaezgGt8naPNPK93zY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q8biabOl05FB1gUCz/EDVfI+FRtECFy1Tb+F1b2tGqzQzDwsVQcgNOV2vBw3drHnm iVtbzdxX3UZ+94nxIYjutSw3BrJmL1q52+WJL2VpijOdrse8/bQMryrqxCRNsRULF6 O8Wkc9zuPeF86cCreJO9f3pwwozQDrhxPeBc4V+CG+CRK9/ru9ABQetD6/s4YhK5Yn dicqbnZ10X2FTwTZa9/FkJgQjKICMZEtAbuIHw87FXpZbzMwkvKHgvTur7/iJuZdi/ 1FnRClzfc8tkrePzTOxvbl4vscRu7aJKk30PG2OrbK7eYyYKiFyN893W9ZK8v2Pytt AifMIwyJxhkfA== Date: Tue, 10 Oct 2023 16:35:53 +0100 From: Conor Dooley To: Mehdi Djait Cc: mchehab@kernel.org, heiko@sntech.de, hverkuil-cisco@xs4all.nl, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, conor+dt@kernel.org, ezequiel@vanguardiasur.com.ar, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, alexandre.belloni@bootlin.com, maxime.chevallier@bootlin.com, paul.kocialkowski@bootlin.com Subject: Re: [PATCH v7 1/3] media: dt-bindings: media: add bindings for Rockchip VIP Message-ID: <20231010-roman-corrode-a68390d5f330@spud> References: Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4l9OsQtFT88SXVQA" Content-Disposition: inline In-Reply-To: --4l9OsQtFT88SXVQA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 10, 2023 at 03:15:04PM +0200, Mehdi Djait wrote: > Add a documentation for the Rockchip Video Input Processor > binding. >=20 > The PX30 SoC is the only platform supported so far. >=20 > Signed-off-by: Mehdi Djait > --- > .../bindings/media/rockchip,px30-vip.yaml | 93 +++++++++++++++++++ > 1 file changed, 93 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/rockchip,px30= -vip.yaml >=20 > diff --git a/Documentation/devicetree/bindings/media/rockchip,px30-vip.ya= ml b/Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml > new file mode 100644 > index 000000000000..41f0cd58372d > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml > @@ -0,0 +1,93 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/rockchip,px30-vip.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip VIP Camera Interface > + > +maintainers: > + - Mehdi Djait > + > +description: |- The |- is not needed here, you've got no fancy formattting to preserve. > + Rockchip VIP is the Video Input Processor of the rockchip PX30 SoC. It > + receives the data from Camera sensor or CCIR656 encoder and transfers = it into > + system main memory by AXI bus. > + > +properties: > + compatible: > + const: rockchip,px30-vip > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: ACLK > + - description: HCLK > + - description: PCLK > + > + clock-names: > + items: > + - const: aclk > + - const: hclk > + - const: pclk > + > + resets: > + items: > + - description: AXI > + - description: AHB > + - description: PCLK IN > + > + reset-names: > + items: > + - const: axi > + - const: ahb > + - const: pclkin > + > + power-domains: > + maxItems: 1 > + > + port: > + $ref: /schemas/graph.yaml#/properties/port > + description: A connection to a sensor or decoder This description seems unneeded also. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + parent { > + #address-cells =3D <2>; > + #size-cells =3D <2>; > + > + vip@ff490000 { This should be a generic node name. > + compatible =3D "rockchip,px30-vip"; > + reg =3D <0x0 0xff490000 0x0 0x200>; > + interrupts =3D ; > + clocks =3D <&cru ACLK_CIF>, <&cru HCLK_CIF>, <&cru PCLK_CIF>; > + clock-names =3D "aclk", "hclk", "pclk"; > + resets =3D <&cru SRST_CIF_A>, <&cru SRST_CIF_H>, <&cru SRST_= CIF_PCLKIN>; > + reset-names =3D "axi", "ahb", "pclkin"; > + power-domains =3D <&power PX30_PD_VI>; Blank line before child nodes please. Otherwise, this looks mostly fine to me. > + port { > + endpoint { > + remote-endpoint =3D <&tw9900_out>; > + }; > + }; > + }; > + }; > +... > --=20 > 2.41.0 >=20 --4l9OsQtFT88SXVQA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZSVvWQAKCRB4tDGHoIJi 0tc5AP98ZFcwCG4lOs0Vnu/l5rmaIRtV2bVB/xqanyAy7JRp1AD/Z4+6tERcvRTL dMHfwEobvX/z0gDzR4EemuU1fnenEAM= =YQ+D -----END PGP SIGNATURE----- --4l9OsQtFT88SXVQA--