From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD16A1FCF for ; Tue, 10 Oct 2023 08:48:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Av5JAAq+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3EF8C433C7; Tue, 10 Oct 2023 08:48:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696927720; bh=Qshdf56p2PmgtMepW/YIwcuyGu3PnxXeQRi+mQdc19M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Av5JAAq+aX0+glsIlI3y2nB4vmBMX3mKRFSg/INBNb0zC5mf+vokPVXizghhdtEtz h2tmZtDPaMQH6tltozkSwBbReKygEodMRVsnSu9FsnMFv0RpDNLAlQagm+Ai5LhWUm vbq0okGFzV5iMx3set7wiTNKkB9iaoLv8TiqM7L3C8xOr6vGF5vVFpKB7wzJcuDSPn 2rpmESqVcA0AYIJ7cbmdyR8XxN7EJ8Qmfd0jb+Cx0MWBq6FIXxQp/3RaW1kkq2FKIy lxtrfy+FBANqLYW+Rn8AFVCAefDezr6IBYNfgmW3+Zx633yLytzImitOvA2Tvi/gE4 euKYABFO3cKpg== Date: Tue, 10 Oct 2023 09:48:51 +0100 From: Jonathan Cameron To: Rob Herring Cc: Geert Uytterhoeven , Andy Shevchenko , Biju Das , Lars-Peter Clausen , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , "linux-iio@vger.kernel.org" , Geert Uytterhoeven , Prabhakar Mahadev Lad , "linux-renesas-soc@vger.kernel.org" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Subject: Re: [PATCH v2 4/5] iio: magnetometer: ak8975: Drop deprecated enums from OF table Message-ID: <20231010094851.3bde8530@jic23-huawei> In-Reply-To: References: <20230818075600.24277-1-biju.das.jz@bp.renesas.com> <20230818075600.24277-5-biju.das.jz@bp.renesas.com> <20230828152137.2db2668d@jic23-huawei> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 6 Oct 2023 09:58:34 -0500 Rob Herring wrote: > On Mon, Aug 28, 2023 at 9:22=E2=80=AFAM Jonathan Cameron wrote: > > > > On Fri, 18 Aug 2023 17:17:44 +0200 > > Geert Uytterhoeven wrote: > > =20 > > > Hi Andy, > > > > > > CC devicetree > > > > > > On Fri, Aug 18, 2023 at 5:03=E2=80=AFPM Andy Shevchenko > > > wrote: =20 > > > > On Fri, Aug 18, 2023 at 11:40:37AM +0000, Biju Das wrote: =20 > > > > > > Subject: Re: [PATCH v2 4/5] iio: magnetometer: ak8975: Drop dep= recated > > > > > > enums from OF table > > > > > > > > > > > > On Fri, Aug 18, 2023 at 08:55:59AM +0100, Biju Das wrote: =20 > > > > > > > Drop deprecated enums from OF table as corresponding entries = are > > > > > > > removed from bindings and it also saves memory. =20 > > > > > > > > > > > > You can't do this. > > > > > > > > > > > > Only sorting by "prefixed first" criteria is possible. =20 > > > > > > > > > > The rule applies only for fallback compatible. I checked bindings= and I don't > > > > > find any fallback compatibles. All compatibles are just enums. Am= I missing > > > > > anything here?? =20 > > > > > > > > Yes. As per above patch. The _whole_ world is not under your / our = control. > > > > NAK to this change, sorry. =20 > > > > > > The single user ever in the upstream kernel was fixed in commit > > > 9846210b1ec9bbaa ("ARM: tegra: seaboard: add missing DT vendor > > > prefixes") in v3.8 back in 2012. > > > And it had to be fixed again 9 years later in commit fa0fdb78cb5d4cde > > > ("ARM: dts: am335x: Use correct vendor prefix for Asahi Kasei Corp."). > > > > > > There may be other out-of-tree users, which would be broken by this > > > change. Typically we wait a few years between deprecating a compatib= le > > > value and removing support from the driver. > > > > > > As Biju is only deprecating these compatible values in PATCH 3/5 of > > > his series, this may be a bit premature. =20 > > Absolutely. I'd go a bit further. > > Unless there is a maintenance reason to remove these (after a few years= from > > removal in the binding doc) then we never remove them as it can only hu= rt users. =20 >=20 > I'm tracking undocumented compatibles (with 'make > dt_compatible_check') in the kernel tree. Dropping the binding makes > these undocumented (and now showing up in my diff between Linus and > next). So please apply both or none. >=20 > Rob Given I have some merges in the togreg tree and it's at least in theory non rebasing, I'll revert patch 3 from this series rather than dropping it. Thanks for letting me know. Jonathan