From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE38FD29C for ; Tue, 10 Oct 2023 11:16:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Sr8jbBk2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F1F3C433C8; Tue, 10 Oct 2023 11:16:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696936565; bh=oSDiFz9Zb1iQ0wk+UooT+QtaLMJpiTRuK/LkyCU0teQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Sr8jbBk2PM1HrJZd04DJkfMTK6sHMvnU2jS3Zv8NHBL/7aYuubGJ2msbs9Ldd7xde 6FEqInITGfsTN0k9ywPBWi0xwrXw6ITo4G0IZ4azYV1WH8RPpj6ZqU/Lpnm75LJM45 /ebLLrD/gLw9PfEp6CpzxuCo7k1paS94u3CSR0KnQj0BwAC3XihyKjTJCOoDnW3/ph BTSkGzFbtQIisvJXYT3vT5eRRbF0KPBIcssTmSjBToC7563on9J7m6vx1p/dVdoLN+ z2ORx892SZynTgWgQ87s6k4pWxwRf9YezVu44AzbUQyjBcto4MDyYWmtEexZePtFoM 2RM13RTq08c8A== Date: Tue, 10 Oct 2023 16:45:50 +0530 From: Manivannan Sadhasivam To: Yoshihiro Shimoda Cc: lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jingoohan1@gmail.com, gustavo.pimentel@synopsys.com, marek.vasut+renesas@gmail.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Serge Semin Subject: Re: [PATCH v21 07/16] PCI: dwc: Expose dw_pcie_write_dbi2() to module Message-ID: <20231010111550.GC4884@thinkpad> References: <20230922065331.3806925-1-yoshihiro.shimoda.uh@renesas.com> <20230922065331.3806925-8-yoshihiro.shimoda.uh@renesas.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230922065331.3806925-8-yoshihiro.shimoda.uh@renesas.com> On Fri, Sep 22, 2023 at 03:53:22PM +0900, Yoshihiro Shimoda wrote: > Since no PCIe controller drivers call this, this change is not required > for now. But, Renesas R-Car Gen4 PCIe controller driver will call this > and if the controller driver is built as a kernel module, the following > build error happens: > > ERROR: modpost: "dw_pcie_write_dbi2" [drivers/pci/controller/dwc/pcie-rcar-gen4-host-drv.ko] undefined! > > So, expose dw_pcie_write_dbi2() for it. > > [kwilczynski: commit log] > Link: https://lore.kernel.org/linux-pci/20230825093219.2685912-12-yoshihiro.shimoda.uh@renesas.com > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Manivannan Sadhasivam (Fix the Link and s-o-b for all patches). - Mani > Signed-off-by: Krzysztof Wilczyński > Reviewed-by: Serge Semin > --- > drivers/pci/controller/dwc/pcie-designware.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c > index 1f900be94556..250cf7f40b85 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.c > +++ b/drivers/pci/controller/dwc/pcie-designware.c > @@ -365,6 +365,7 @@ void dw_pcie_write_dbi2(struct dw_pcie *pci, u32 reg, size_t size, u32 val) > if (ret) > dev_err(pci->dev, "write DBI address failed\n"); > } > +EXPORT_SYMBOL_GPL(dw_pcie_write_dbi2); > > static inline void __iomem *dw_pcie_select_atu(struct dw_pcie *pci, u32 dir, > u32 index) > -- > 2.25.1 > -- மணிவண்ணன் சதாசிவம்