From: Conor Dooley <conor@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
bard.liao@intel.com, Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 4/4] dt-bindings: audio-graph-port: ch_maps property
Date: Wed, 11 Oct 2023 14:58:14 +0100 [thread overview]
Message-ID: <20231011-crazily-mangy-2302e41eb743@spud> (raw)
In-Reply-To: <87h6mx1yrp.wl-kuninori.morimoto.gx@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]
Hey,
On Wed, Oct 11, 2023 at 06:03:38AM +0000, Kuninori Morimoto wrote:
> This patch adds ch_maps property to enable handling CPU:Codec = N:M
> connection.
I only got this one patch, so I have no context at all for this change.
Given that, and since I know almost nothing about sound stuff...
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> Documentation/devicetree/bindings/sound/audio-graph-port.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> index 60b5e3fd1115..dc663af784fd 100644
> --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> @@ -19,6 +19,8 @@ definitions:
> properties:
> mclk-fs:
> $ref: simple-card.yaml#/definitions/mclk-fs
> + ch_maps:
...I have absolutely no idea how I would populate "ch_maps" correctly.
Please describe (in the binding) what this property actually does
& how to use it. Also, properties use -s not _s.
Thanks,
Conor.
> + $ref: /schemas/types.yaml#/definitions/uint32-array
>
> endpoint-base:
> allOf:
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2023-10-11 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87mswp1ytu.wl-kuninori.morimoto.gx@renesas.com>
2023-10-11 6:03 ` [PATCH v2 4/4] dt-bindings: audio-graph-port: ch_maps property Kuninori Morimoto
2023-10-11 13:58 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231011-crazily-mangy-2302e41eb743@spud \
--to=conor@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox