From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC46819BB9 for ; Wed, 11 Oct 2023 08:58:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="FOt/wJLM" Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02A4E94; Wed, 11 Oct 2023 01:58:33 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 22CBB1BF205; Wed, 11 Oct 2023 08:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1697014712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CA6rrOtZmd//pxStu/MQQ9YaVAFhDGXG/6MyKvrCXME=; b=FOt/wJLMIbFD7NVrzal7GYPjlqoc6eFpCG2Dj3W9q6b+1nyAlJarLNljEUsLRasCH7tOT9 PA+EAkEyM+pshhwoVX7VFVTNYXXadQLSIHN/UC61hm2Zj24aJajNtE9mTqgL8LpcrdIn5V 5+dtoMnY/9Uq+SJS3wSKRYUA8xTKN04DjDczCgKXx84V77u+b5CC1OPuzPFXSqQQFd6sw2 UQ/eri3cxE1o11XcDOMcVcnc5INsSMJlrz3YVkubWly0fgF78xyaKxj2b9h0qbOkq3j5gV lxdg+/jgjFd49UE9u8qVbo3tFMetnR5b7AhP9Syd0ugptmnvPQtPuHKNNHA94A== Date: Wed, 11 Oct 2023 10:58:29 +0200 From: Miquel Raynal To: Srinivas Kandagatla Cc: Greg Kroah-Hartman , Michael Walle , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Rob Herring , Frank Rowand , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Robert Marko , Thomas Petazzoni , Luka Perkov , Randy Dunlap , Chen-Yu Tsai , Daniel Golle Subject: Re: [PATCH v12 7/7] nvmem: core: Expose cells through sysfs Message-ID: <20231011105829.778bed58@xps-13> In-Reply-To: References: <20231005155907.2701706-1-miquel.raynal@bootlin.com> <20231005155907.2701706-8-miquel.raynal@bootlin.com> <318fe799-f53e-64ed-b631-d099bb5202f4@linaro.org> <20231011091524.0c9ecc55@xps-13> <548849a8-9f11-5274-778e-f291267603bb@linaro.org> <20231011103306.08f1fbd4@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Hi Srinivas, srinivas.kandagatla@linaro.org wrote on Wed, 11 Oct 2023 09:45:11 +0100: > On 11/10/2023 09:33, Miquel Raynal wrote: > > Hi Srinivas, > >=20 > > srinivas.kandagatla@linaro.org wrote on Wed, 11 Oct 2023 09:27:20 +0100: > > =20 > >> On 11/10/2023 08:15, Miquel Raynal wrote: =20 > >>>>> + > >>>>> + nvmem_cells_group.bin_attrs =3D cells_attrs; > >>>>> + > >>>>> + ret =3D devm_device_add_groups(&nvmem->dev, nvmem_cells_groups); > >>>>> + if (ret) > >>>>> + goto unlock_mutex; =20 > >>>> This is going to create groups after the nvmem device is added, isn'= t this going to be problem with user space notifications? =20 > >>> Greg said it was not. I hope I understood correctly =F0=9F=98=84 > >>> > >>> And anyway, cells have never been available to userspace, so there is > >>> nothing userspace might expect yet? =20 > >> I agree, but once we add sysfs uapi then this is going to change. =20 > >=20 > > Can you elaborate? I'm not sure I follow you here. Is there still a > > problem you fear or you think it's okay? > > =20 > Now that we add cells to sysfs. > AFAIU, By the time the userspace sees the udev event from this device we = might not have cells populated. Yes, but why would this be a problem? Thanks, Miqu=C3=A8l