From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Frank Li <Frank.li@nxp.com>
Cc: aisheng.dong@nxp.com, bhelgaas@google.com,
devicetree@vger.kernel.org, festevam@gmail.com,
imx@lists.linux.dev, jdmason@kudzu.us, kernel@pengutronix.de,
kishon@kernel.org, kw@linux.com,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
lorenzo.pieralisi@arm.com, lpieralisi@kernel.org, maz@kernel.org,
s.hauer@pengutronix.de, shawnguo@kernel.org, tglx@linutronix.de
Subject: Re: [PATCH v2 0/5] Add RC-to-EP doorbell with platform MSI controller
Date: Mon, 16 Oct 2023 22:46:37 +0530 [thread overview]
Message-ID: <20231016171637.GJ39962@thinkpad> (raw)
In-Reply-To: <ZS1N0jgGYfmMsgrJ@lizhi-Precision-Tower-5810>
On Mon, Oct 16, 2023 at 10:50:58AM -0400, Frank Li wrote:
> On Tue, Oct 10, 2023 at 10:21:24AM -0400, Frank Li wrote:
> > On Sat, Sep 30, 2023 at 11:02:49AM +0200, Manivannan Sadhasivam wrote:
> > > On Wed, Sep 20, 2023 at 05:39:48PM -0400, Frank Li wrote:
> > > > On Mon, Sep 11, 2023 at 06:09:15PM -0400, Frank Li wrote:
> > > > > ┌────────────┐ ┌───────────────────────────────────┐ ┌────────────────┐
> > > > > │ │ │ │ │ │
> > > > > │ │ │ PCI Endpoint │ │ PCI Host │
> > > > > │ │ │ │ │ │
> > > > > │ │◄──┤ 1.platform_msi_domain_alloc_irqs()│ │ │
> > > > > │ │ │ │ │ │
> > > > > │ MSI ├──►│ 2.write_msi_msg() ├──►├─BAR<n> │
> > > > > │ Controller │ │ update doorbell register address│ │ │
> > > > > │ │ │ for BAR │ │ │
> > > > > │ │ │ │ │ 3. Write BAR<n>│
> > > > > │ │◄──┼───────────────────────────────────┼───┤ │
> > > > > │ │ │ │ │ │
> > > > > │ ├──►│ 4.Irq Handle │ │ │
> > > > > │ │ │ │ │ │
> > > > > │ │ │ │ │ │
> > > > > └────────────┘ └───────────────────────────────────┘ └────────────────┘
> > > >
> > > > @mani:
> > > > Do you have chance to review this patch again?
> > >
> > > I was on vacation for past few weeks. Will take a look in the coming week.
> >
> > Ping?
> >
> > Frank
>
> @mani: did you have chance to look at this?
>
Sorry for the long delay. I will take a look tomorrow.
- Mani
> >
> > >
> > > - Mani
> > >
> > > >
> > > > Frank
> > > >
> > > > >
> > > > > This patches based on old https://lore.kernel.org/imx/20221124055036.1630573-1-Frank.Li@nxp.com/
> > > > >
> > > > > Original patch only target to vntb driver. But actually it is common
> > > > > method.
> > > > >
> > > > > This patches add new API to pci-epf-core, so any EP driver can use it.
> > > > >
> > > > > The key point is comments from Thomas Gleixner, who suggest use new
> > > > > PCI/IMS. But arm platform change still not be merged yet.
> > > > >
> > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git devmsi-v2-arm
> > > > >
> > > > > So I still use existed method implement RC to EP doorbell.
> > > > >
> > > > > If Thomas Gleixner want to continue work on devmsi-v2-arm, I can help test
> > > > > and update this patch.
> > > > >
> > > > > Change from v1 to v2
> > > > > - Add missed patch for endpont/pci-epf-test.c
> > > > > - Move alloc and free to epc driver from epf.
> > > > > - Provide general help function for EPC driver to alloc platform msi irq.
> > > > > - Fixed manivannan's comments.
> > > > >
> > > > > Frank Li (5):
> > > > > PCI: endpoint: Add RC-to-EP doorbell support using platform MSI
> > > > > controller
> > > > > PCI: dwc: add doorbell support by use MSI controller
> > > > > PCI: endpoint: pci-epf-test: add doorbell test
> > > > > misc: pci_endpoint_test: Add doorbell test case
> > > > > tools: PCI: Add 'B' option for test doorbell
> > > > >
> > > > > drivers/misc/pci_endpoint_test.c | 48 +++++
> > > > > .../pci/controller/dwc/pcie-designware-ep.c | 2 +
> > > > > drivers/pci/endpoint/functions/pci-epf-test.c | 59 +++++-
> > > > > drivers/pci/endpoint/pci-epc-core.c | 192 ++++++++++++++++++
> > > > > drivers/pci/endpoint/pci-epf-core.c | 44 ++++
> > > > > include/linux/pci-epc.h | 6 +
> > > > > include/linux/pci-epf.h | 7 +
> > > > > include/uapi/linux/pcitest.h | 1 +
> > > > > tools/pci/pcitest.c | 16 +-
> > > > > 9 files changed, 373 insertions(+), 2 deletions(-)
> > > > >
> > > > > --
> > > > > 2.34.1
> > > > >
> > >
> > > --
> > > மணிவண்ணன் சதாசிவம்
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-10-16 17:16 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 22:09 [PATCH v2 0/5] Add RC-to-EP doorbell with platform MSI controller Frank Li
2023-09-11 22:09 ` [PATCH v2 1/5] PCI: endpoint: Add RC-to-EP doorbell support using " Frank Li
2023-09-29 9:30 ` Kishon Vijay Abraham I
2023-09-29 14:39 ` Frank Li
2023-10-17 18:37 ` Manivannan Sadhasivam
2023-10-17 18:55 ` Frank Li
2023-10-19 15:04 ` Manivannan Sadhasivam
2023-10-19 16:00 ` Frank Li
2023-10-19 17:23 ` Manivannan Sadhasivam
2023-10-19 18:11 ` [PATCH v2 1/5] PCI: endpoint: Add RC-to-EP doorbell support using platform MSI controllery Frank Li
2023-10-20 17:12 ` Manivannan Sadhasivam
2023-10-20 18:00 ` Frank Li
2023-10-20 18:10 ` Manivannan Sadhasivam
2023-09-11 22:09 ` [PATCH v2 2/5] PCI: dwc: add doorbell support by use MSI controller Frank Li
2023-09-11 22:09 ` [PATCH v2 3/5] PCI: endpoint: pci-epf-test: add doorbell test Frank Li
2023-09-29 9:33 ` Kishon Vijay Abraham I
2023-09-29 14:26 ` Frank Li
2023-10-20 17:44 ` Manivannan Sadhasivam
2023-09-11 22:09 ` [PATCH v2 4/5] misc: pci_endpoint_test: Add doorbell test case Frank Li
2023-10-20 17:53 ` Manivannan Sadhasivam
2023-10-20 18:01 ` Manivannan Sadhasivam
2023-10-20 18:07 ` Frank Li
2023-10-20 18:26 ` Manivannan Sadhasivam
2023-10-30 18:33 ` Frank Li
2023-11-02 17:58 ` Manivannan Sadhasivam
2023-11-09 4:44 ` Kishon Vijay Abraham I
2023-09-11 22:09 ` [PATCH v2 5/5] tools: PCI: Add 'B' option for test doorbell Frank Li
2023-10-20 17:55 ` Manivannan Sadhasivam
2023-09-20 21:39 ` [PATCH v2 0/5] Add RC-to-EP doorbell with platform MSI controller Frank Li
2023-09-30 9:02 ` Manivannan Sadhasivam
2023-10-10 14:21 ` Frank Li
2023-10-16 14:50 ` Frank Li
2023-10-16 17:16 ` Manivannan Sadhasivam [this message]
2024-10-09 16:01 ` Niklas Cassel
2024-10-09 16:20 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016171637.GJ39962@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=Frank.li@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jdmason@kudzu.us \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).