public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Daniel Beer <daniel.beer@igorinstitute.com>,
	alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: tas5805m: Disallow undefined properties
Date: Tue, 17 Oct 2023 11:50:42 +0100	[thread overview]
Message-ID: <20231017-blinking-barricade-9e068a5fc602@spud> (raw)
In-Reply-To: <20231016155547.2973853-1-robh@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

On Mon, Oct 16, 2023 at 10:55:47AM -0500, Rob Herring wrote:
> Device specific bindings should not allow undefined properties. This is
> accomplished in json-schema with 'additionalProperties: false'.
> 
> Examples should be last in the schema, so move additionalProperties up
> while we're here.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/sound/tas5805m.yaml | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/tas5805m.yaml b/Documentation/devicetree/bindings/sound/tas5805m.yaml
> index 63edf52f061c..12c41974274e 100644
> --- a/Documentation/devicetree/bindings/sound/tas5805m.yaml
> +++ b/Documentation/devicetree/bindings/sound/tas5805m.yaml
> @@ -37,6 +37,8 @@ properties:
>        generated from TI's PPC3 tool.
>      $ref: /schemas/types.yaml#/definitions/string
>  
> +additionalProperties: false
> +
>  examples:
>    - |
>      i2c {
> @@ -52,5 +54,4 @@ examples:
>                  ti,dsp-config-name = "mono_pbtl_48khz";
>          };
>      };
> -
> -additionalProperties: true
> +...
> -- 
> 2.42.0
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-10-17 10:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-16 15:55 [PATCH] ASoC: dt-bindings: tas5805m: Disallow undefined properties Rob Herring
2023-10-17 10:50 ` Conor Dooley [this message]
2023-10-17 11:29   ` Mark Brown
2023-10-17 17:39 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231017-blinking-barricade-9e068a5fc602@spud \
    --to=conor@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.beer@igorinstitute.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox