[PATCH] dt-bindings: usb: vialab,vl817: remove reset-gpios from required list

[PATCH] dt-bindings: usb: vialab,vl817: remove reset-gpios from required list

[Jisheng Zhang]

The "reset-gpios" is optional in real case, for example reset pin is
is hard wired to "high". And this fact is also reflected by the
devm_gpio_get_optional() calling in driver code.

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
 .../bindings/usb/thead,th1520-usb.yaml        | 42 ++++++++++---------
 .../devicetree/bindings/usb/vialab,vl817.yaml |  1 -
 2 files changed, 23 insertions(+), 20 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml b/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml
index afb618eb5013..ce1cab75f0ff 100644
--- a/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml
+++ b/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml
@@ -28,6 +28,10 @@ properties:
 
   ranges: true
 
+  thead,misc-syscon:
+    $ref: /schemas/types.yaml#/definitions/phandle-array
+    description: a phandle to the misc system register controller syscon node.
+
   '#address-cells':
     enum: [ 1, 2 ]
 
@@ -51,23 +55,23 @@ additionalProperties: false
 
 examples:
   - |
-
-    usb {
-          compatible = "thead,th1520-usb";
-          reg = <0xec03f000 0x1000>;
-          clocks = <&clk 1>,
-                   <&clk 2>,
-                   <&clk 3>,
-                   <&clk 4>;
-          clock-names = "ref", "bus_early", "phy", "suspend";
-          ranges;
-          #address-cells = <1>;
-          #size-cells = <1>;
-
-          usb@e7040000 {
-                compatible = "snps,dwc3";
-                reg = <0xe7040000 0x10000>;
-                interrupts = <68>;
-                dr_mode = "host";
-          };
+    usb@ec03f000 {
+        compatible = "thead,th1520-usb";
+        reg = <0xec03f000 0x1000>;
+        thead,misc-syscon = <&misc_syscon>;
+        clocks = <&clk 1>,
+                 <&clk 2>,
+                 <&clk 3>,
+                 <&clk 4>;
+        clock-names = "ref", "bus_early", "phy", "suspend";
+        ranges;
+        #address-cells = <1>;
+        #size-cells = <1>;
+
+        usb@e7040000 {
+            compatible = "snps,dwc3";
+            reg = <0xe7040000 0x10000>;
+            interrupts = <68>;
+            dr_mode = "host";
+        };
     };
diff --git a/Documentation/devicetree/bindings/usb/vialab,vl817.yaml b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml
index 76db9071b352..c815010ba9c2 100644
--- a/Documentation/devicetree/bindings/usb/vialab,vl817.yaml
+++ b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml
@@ -37,7 +37,6 @@ properties:
 required:
   - compatible
   - reg
-  - reset-gpios
   - vdd-supply
   - peer-hub
 
-- 
2.40.1

Re: [PATCH] dt-bindings: usb: vialab,vl817: remove reset-gpios from required list

[Krzysztof Kozlowski]

On 17/10/2023 18:01, Jisheng Zhang wrote:
> The "reset-gpios" is optional in real case, for example reset pin is
> is hard wired to "high". And this fact is also reflected by the
> devm_gpio_get_optional() calling in driver code.
> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
>  .../bindings/usb/thead,th1520-usb.yaml        | 42 ++++++++++---------
>  .../devicetree/bindings/usb/vialab,vl817.yaml |  1 -
>  2 files changed, 23 insertions(+), 20 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml b/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml
> index afb618eb5013..ce1cab75f0ff 100644
> --- a/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml
> +++ b/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml
> @@ -28,6 +28,10 @@ properties:
>  
>    ranges: true
>  
> +  thead,misc-syscon:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    description: a phandle to the misc system register controller syscon node.

Either you combined two unrelated changes or this should be resets from
reset-controller.


Best regards,
Krzysztof

Re: [PATCH] dt-bindings: usb: vialab,vl817: remove reset-gpios from required list

[Jisheng Zhang]

On Tue, Oct 17, 2023 at 06:53:56PM +0200, Krzysztof Kozlowski wrote:
> On 17/10/2023 18:01, Jisheng Zhang wrote:
> > The "reset-gpios" is optional in real case, for example reset pin is
> > is hard wired to "high". And this fact is also reflected by the
> > devm_gpio_get_optional() calling in driver code.
> > 
> > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > ---
> >  .../bindings/usb/thead,th1520-usb.yaml        | 42 ++++++++++---------
> >  .../devicetree/bindings/usb/vialab,vl817.yaml |  1 -
> >  2 files changed, 23 insertions(+), 20 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml b/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml
> > index afb618eb5013..ce1cab75f0ff 100644
> > --- a/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml
> > +++ b/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml
> > @@ -28,6 +28,10 @@ properties:
> >  
> >    ranges: true
> >  
> > +  thead,misc-syscon:
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > +    description: a phandle to the misc system register controller syscon node.
> 
> Either you combined two unrelated changes or this should be resets from
> reset-controller.

oops, this change isn't expected... I was working on TH1520 usb but
add local changes step by step, but then found vl817 need to be patched.
I forgot to reset TH1520 usb part. Sorry for noise. V2 will be sent out
soon.