devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Dmitry Rokosov <ddrokosov@salutedevices.com>
Cc: lee@kernel.org, pavel@ucw.cz, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	andy.shevchenko@gmail.com, kernel@sberdevices.ru,
	rockosov@gmail.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 11/11] dt-bindings: leds: aw200xx: fix led pattern and add reg constraints
Date: Thu, 19 Oct 2023 15:08:38 +0100	[thread overview]
Message-ID: <20231019-clarify-unstopped-71fe018b6a8b@spud> (raw)
In-Reply-To: <20231018182943.18700-12-ddrokosov@salutedevices.com>

[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]

On Wed, Oct 18, 2023 at 09:29:43PM +0300, Dmitry Rokosov wrote:
> AW200XX controllers have the capability to declare more than 0xf LEDs,
> therefore, it is necessary to accept LED names using an appropriate
> regex pattern.
> 
> The register offsets can be adjusted within the specified range, with
> the maximum value corresponding to the highest number of LEDs that can
> be connected to the controller.

Do all of these controllers have identical max numbers of LEDs?

Cheers,
Conor.

> 
> Fixes: e338a05e76ca ("dt-bindings: leds: Add binding for AW200xx")
> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
> ---
>  .../devicetree/bindings/leds/awinic,aw200xx.yaml       | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml
> index efb18ddce383..677c73aa6232 100644
> --- a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml
> +++ b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml
> @@ -42,16 +42,18 @@ properties:
>      maxItems: 1
>  
>  patternProperties:
> -  "^led@[0-9a-f]$":
> +  "^led@[0-9a-f]+$":
>      type: object
>      $ref: common.yaml#
>      unevaluatedProperties: false
>  
>      properties:
>        reg:
> -        description:
> -          LED number
> -        maxItems: 1
> +        items:
> +          description:
> +            LED number
> +          minimum: 0
> +          maximum: 108
>  
>        led-max-microamp:
>          default: 9780
> -- 
> 2.36.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-10-19 14:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18 18:29 [PATCH v2 00/11] leds: aw200xx: several driver updates Dmitry Rokosov
2023-10-18 18:29 ` [PATCH v2 01/11] leds: aw200xx: fix write to DIM parameter Dmitry Rokosov
2023-10-18 18:29 ` [PATCH v2 02/11] leds: aw200xx: support HWEN hardware control Dmitry Rokosov
2023-10-19  8:56   ` Andy Shevchenko
2023-10-18 18:29 ` [PATCH v2 03/11] dt-bindings: leds: aw200xx: introduce optional hwen-gpios property Dmitry Rokosov
2023-10-19 14:11   ` Conor Dooley
2023-10-24 18:54     ` Dmitry Rokosov
2023-10-24 18:30   ` Rob Herring
2023-10-24 18:52     ` [DMARC error] " Dmitry Rokosov
2023-10-25  7:58       ` Krzysztof Kozlowski
2023-10-18 18:29 ` [PATCH v2 04/11] leds: aw200xx: calculate dts property display_rows in driver Dmitry Rokosov
2023-10-19  9:01   ` Andy Shevchenko
2023-10-19 19:25     ` George Stark
2023-10-18 18:29 ` [PATCH v2 05/11] dt-bindings: leds: aw200xx: remove property "awinic,display-rows" Dmitry Rokosov
2023-10-18 18:29 ` [PATCH v2 06/11] leds: aw200xx: add delay after software reset Dmitry Rokosov
2023-10-19  9:03   ` Andy Shevchenko
2023-10-18 18:29 ` [PATCH v2 07/11] leds: aw200xx: enable disable_locking flag in regmap config Dmitry Rokosov
2023-10-18 18:29 ` [PATCH v2 08/11] leds: aw200xx: improve autodim calculation method Dmitry Rokosov
2023-10-18 18:29 ` [PATCH v2 09/11] leds: aw200xx: add support for aw20108 device Dmitry Rokosov
2023-10-19  9:10   ` Andy Shevchenko
2023-10-19  9:12     ` Andy Shevchenko
2023-10-18 18:29 ` [PATCH v2 10/11] dt-bindings: leds: awinic,aw200xx: add AW20108 device Dmitry Rokosov
2023-10-19 14:07   ` Conor Dooley
2023-10-18 18:29 ` [PATCH v2 11/11] dt-bindings: leds: aw200xx: fix led pattern and add reg constraints Dmitry Rokosov
2023-10-19 14:08   ` Conor Dooley [this message]
2023-10-24 18:56     ` Dmitry Rokosov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231019-clarify-unstopped-71fe018b6a8b@spud \
    --to=conor@kernel.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=ddrokosov@salutedevices.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@sberdevices.ru \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=rockosov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).