From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96DDA15E81; Fri, 20 Oct 2023 10:01:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WAt6zkRr" Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88394D66; Fri, 20 Oct 2023 03:00:58 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4064876e8b8so5430605e9.0; Fri, 20 Oct 2023 03:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697796056; x=1698400856; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=peRqXjQQQ45HJmDIxv6CwSEgU//1lNonAjtSzwx3PGU=; b=WAt6zkRrXTXbvp7uV9zadEt2O1sBo7iFog6EsgZnH/d3Pk1Dz2kI3NFcdhF5UN7hm4 mXtMixQebrkU7+DXfCSEavCu7vXffxc1vdFZjcuP+eqZRMvncs0hX67kN2dYefUXEXcp W9Qo//N9Av9pmWUnX8CAUVN4Te2RwVLOlRQrFs/PnWegi56YuLU7tuxhLCqhpbEt6ZNY GswuoyV5wn8lq6i9RqyjLWurTb+L7rri57jXx5riMLTjuG4EX3d7MTE/+8Ju5CWcd1RW QipibBOLPnpLWdJvh5eHoCHNy/GDohXkMyqG1m/cFeTaMUJxMavubDluUcc5eRuFPa59 wy+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697796056; x=1698400856; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=peRqXjQQQ45HJmDIxv6CwSEgU//1lNonAjtSzwx3PGU=; b=wzC2xsfrFnhPeh26GH24fQNurpsxq4ffcFHUnqUBgV08SwVvHFFg6V9vmPfDsCVMhU QtzGXA+SISdVVdEr9gb3tTUNS+9fIlTJbZMfumKTO17WbgW4mqdhB25lrBrTKOIl379G Suc6esTWrftN5qo2TnE65ENXkdTzmjFgSClA9wPXssGKigdHaOv4oeyUaAcNzVXukX22 UIcaZruBlf+qQtK2jmvdNq43BCUoly4J5fY7bnx6DZUwuaydaop9bhfjj4fPlwJTYiOu ErjCf/0sYzJz7OI+sSVAeStgrbJtU6scnPm4njo4uG1D7ap+0NIta/esqmdhEo5NyPOC 2FJA== X-Gm-Message-State: AOJu0YzSNzzfWgoEMVWe2vP4Vo9cFeUH+/MLoq8KB4EvrFbPDp0wdJML /vYDFreDmezL2A+uFE4TBBE= X-Google-Smtp-Source: AGHT+IHsoOcv7yGlkWUObueKECjKOC+XTO4SUe7WvsjAk0W10IRiMeQ2aLBhTMS9jRCqxjmQxecx/Q== X-Received: by 2002:adf:f387:0:b0:319:68ce:2c53 with SMTP id m7-20020adff387000000b0031968ce2c53mr991596wro.25.1697796056321; Fri, 20 Oct 2023 03:00:56 -0700 (PDT) Received: from skbuf ([188.26.57.160]) by smtp.gmail.com with ESMTPSA id d14-20020adffd8e000000b0031984b370f2sm1320027wrr.47.2023.10.20.03.00.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 03:00:55 -0700 (PDT) Date: Fri, 20 Oct 2023 13:00:53 +0300 From: Vladimir Oltean To: Ante Knezic Cc: UNGLinuxDriver@microchip.com, andrew@lunn.ch, conor+dt@kernel.org, davem@davemloft.net, devicetree@vger.kernel.org, edumazet@google.com, f.fainelli@gmail.com, krzysztof.kozlowski+dt@linaro.org, kuba@kernel.org, linux-kernel@vger.kernel.org, marex@denx.de, netdev@vger.kernel.org, pabeni@redhat.com, robh+dt@kernel.org, woojung.huh@microchip.com Subject: Re: [PATCH net-next v3 2/2] net:dsa:microchip: add property to select Message-ID: <20231020100053.wf3jivdkdfaunfgh@skbuf> References: <20231019165409.5sgkyvxsidrrptgh@skbuf> <20231020084620.4603-1-ante.knezic@helmholz.de> <20231020092729.gpbr7s2cbmznmal7@skbuf> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231020092729.gpbr7s2cbmznmal7@skbuf> On Fri, Oct 20, 2023 at 12:27:29PM +0300, Vladimir Oltean wrote: > On Fri, Oct 20, 2023 at 10:46:20AM +0200, Ante Knezic wrote: > > Ok, will do. I am guessing I should leave the existing > > ksz8795_cpu_interface_select() as it is? > > I would encourage moving it to the simpler call path as well, but > ultimately this is up to you. Also, could you please put spaces in the commit prefix ("net: dsa: microchip: ")?