From: Vladimir Oltean <olteanv@gmail.com>
To: Ante Knezic <ante.knezic@helmholz.de>,
Oleksij Rempel <o.rempel@pengutronix.de>
Cc: UNGLinuxDriver@microchip.com, andrew@lunn.ch,
conor+dt@kernel.org, davem@davemloft.net,
devicetree@vger.kernel.org, edumazet@google.com,
f.fainelli@gmail.com, krzysztof.kozlowski+dt@linaro.org,
kuba@kernel.org, linux-kernel@vger.kernel.org, marex@denx.de,
netdev@vger.kernel.org, pabeni@redhat.com, robh+dt@kernel.org,
woojung.huh@microchip.com
Subject: Re: [PATCH net-next v3 2/2] net:dsa:microchip: add property to select
Date: Fri, 20 Oct 2023 13:26:19 +0300 [thread overview]
Message-ID: <20231020102619.67fc3aaknvukwij4@skbuf> (raw)
In-Reply-To: <20231020100053.wf3jivdkdfaunfgh@skbuf>
+Oleksij
On Fri, Oct 20, 2023 at 01:00:53PM +0300, Vladimir Oltean wrote:
> On Fri, Oct 20, 2023 at 12:27:29PM +0300, Vladimir Oltean wrote:
> > On Fri, Oct 20, 2023 at 10:46:20AM +0200, Ante Knezic wrote:
> > > Ok, will do. I am guessing I should leave the existing
> > > ksz8795_cpu_interface_select() as it is?
> >
> > I would encourage moving it to the simpler call path as well, but
> > ultimately this is up to you.
>
> Also, could you please put spaces in the commit prefix ("net: dsa: microchip: ")?
One more thing. You two are working on separate things on the KSZ
driver (Oleksij on
https://patchwork.kernel.org/project/netdevbpf/cover/20231019122850.1199821-1-o.rempel@pengutronix.de/),
and this creates conflicts in the DT schema and in ksz_common.h.
For the most part, those are avoidable. Could you coordinate so that
both of your next submissions do not conflict with each other? That
means that each of your series can be applied independently of the other
(Ante's first, or Oleksij's first).
For example, the dt-schema properties do not seem alphabetically sorted
(microchip,synclko-125 comes after reset-gpios), so putting
wakeup-source after reset-gpios, and leaving microchip,rmii-clk-internal
at the end, seems a viable strategy in avoiding that conflict.
The conflict in ksz_common.h will be automatically avoided when
rmii_clk_internal stops being stored in struct ksz_device.
prev parent reply other threads:[~2023-10-20 10:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 9:24 [PATCH net-next v3 0/2] net: dsa: microchip: enable setting rmii reference Ante Knezic
2023-10-18 9:24 ` [PATCH net-next v3 1/2] dt-bindings: net: microchip,ksz: document microchip,rmii-clk-internal Ante Knezic
2023-10-18 9:24 ` [PATCH net-next v3 2/2] net:dsa:microchip: add property to select internal RMII reference clock Ante Knezic
2023-10-18 13:52 ` Andrew Lunn
2023-10-18 14:06 ` [PATCH net-next v3 2/2] net:dsa:microchip: add property to select Ante Knezic
2023-10-18 14:09 ` Andrew Lunn
2023-10-19 16:54 ` [PATCH net-next v3 2/2] net:dsa:microchip: add property to select internal RMII reference clock Vladimir Oltean
2023-10-20 8:46 ` [PATCH net-next v3 2/2] net:dsa:microchip: add property to select Ante Knezic
2023-10-20 9:27 ` Vladimir Oltean
2023-10-20 10:00 ` Vladimir Oltean
2023-10-20 10:26 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020102619.67fc3aaknvukwij4@skbuf \
--to=olteanv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=ante.knezic@helmholz.de \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox