From: Vladimir Oltean <olteanv@gmail.com>
To: Ante Knezic <ante.knezic@helmholz.de>
Cc: netdev@vger.kernel.org, woojung.huh@microchip.com,
andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, marex@denx.de, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com,
o.rempel@pengutronix.de
Subject: Re: [PATCH net-next v4 2/2] net: dsa: microchip: add property to select internal RMII reference clock
Date: Fri, 20 Oct 2023 17:37:59 +0300 [thread overview]
Message-ID: <20231020143759.eknrcfbztrc543mm@skbuf> (raw)
In-Reply-To: <492ba34018bd5035bcc33402746df121df172f73.1697811160.git.ante.knezic@helmholz.de>
On Fri, Oct 20, 2023 at 04:25:04PM +0200, Ante Knezic wrote:
> +static void ksz88x3_config_rmii_clk(struct ksz_device *dev)
> +{
> + bool rmii_clk_internal;
> +
> + if (!ksz_is_ksz88x3(dev))
> + return;
> +
> + rmii_clk_internal = of_property_read_bool(dev->dev->of_node,
> + "microchip,rmii-clk-internal");
> +
> + ksz_cfg(dev, KSZ88X3_REG_FVID_AND_HOST_MODE,
> + KSZ88X3_PORT3_RMII_CLK_INTERNAL, rmii_clk_internal);
> +}
Sorry, I didn't realize on v3 that you didn't completely apply my
feedback on v2. Can "microchip,rmii-clk-internal" be a port device tree
property? You have indeed moved its parsing to port code, but it is
still located directly under the switch node in the device tree.
I'm thinking that if this property was also applicable to other switches
with multiple RMII ports, the setting would be per port rather than global.
next prev parent reply other threads:[~2023-10-20 14:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 14:25 [PATCH net-next v4 0/2] net: dsa: microchip: enable setting rmii reference Ante Knezic
2023-10-20 14:25 ` [PATCH net-next v4 1/2] dt-bindings: net: microchip,ksz: document microchip,rmii-clk-internal Ante Knezic
2023-10-20 15:45 ` Conor Dooley
2023-10-20 14:25 ` [PATCH net-next v4 2/2] net: dsa: microchip: add property to select internal RMII reference clock Ante Knezic
2023-10-20 14:37 ` Vladimir Oltean [this message]
2023-10-23 7:27 ` [PATCH net-next v4 2/2] net:dsa:microchip: add property to select Ante Knezic
2023-10-23 7:58 ` Oleksij Rempel
2023-10-23 8:22 ` Ante Knezic
2023-10-23 8:41 ` Oleksij Rempel
2023-10-23 8:57 ` Ante Knezic
2023-10-23 11:49 ` Oleksij Rempel
2023-10-23 12:41 ` Ante Knezic
2023-10-23 14:36 ` Oleksij Rempel
2023-10-24 7:56 ` Ante Knezic
2023-10-24 10:09 ` Oleksij Rempel
2023-10-24 13:08 ` Ante Knezic
2023-10-24 14:24 ` Oleksij Rempel
2023-10-27 6:37 ` Ante Knezic
2023-10-30 17:42 ` Vladimir Oltean
2023-10-31 1:00 ` Andrew Lunn
2023-10-31 7:28 ` Oleksij Rempel
2023-11-02 10:44 ` Vladimir Oltean
2023-10-31 6:27 ` Oleksij Rempel
2023-10-23 12:19 ` Vladimir Oltean
2023-10-23 12:46 ` Ante Knezic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020143759.eknrcfbztrc543mm@skbuf \
--to=olteanv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=ante.knezic@helmholz.de \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).