Re: [PATCH net-next v4 2/2] net:dsa:microchip: add property to select

Ante Knezic
2023-10-27T06:37:56Z

On Tue, 24 Oct 2023 16:24:26 +0200, Oleksij Rampel wrote:

> > That is correct, I guess its a matter of nomenclature, but how do you
> > "tell" the switch whether it has REFCLKI routed externally or not if not by
> > setting the 0xC6 bit 3? Is there another way to achieve this?
>
> I do not see any other way to "tell" it. The only thing to change in you
> patches is a different way to tell it to the kernel.
> Instead of introducing a new devicetree property, you need to reuse
> phy-mode property.

> ...

> Since phy-mode for RMII was never set correctly, it will most probably
> break every single devicetree using KSZ switches. It is the price of fixing
> things :/

To Vladimir Oltean: What are your thoughts on this?