Devicetree
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Mark Brown <broonie@kernel.org>,
	Bard Liao <yung-chuan.liao@linux.intel.com>,
	bard.liao@intel.com, Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	alsa-devel@alsa-project.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 5/5] dt-bindings: audio-graph-port: add ch-map-idx property
Date: Tue, 24 Oct 2023 16:28:07 +0100	[thread overview]
Message-ID: <20231024-preheated-parasail-34d75ee63244@spud> (raw)
In-Reply-To: <87v8axj698.wl-kuninori.morimoto.gx@renesas.com>

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

On Mon, Oct 23, 2023 at 10:58:28PM +0000, Kuninori Morimoto wrote:
> 
> Hi Conor
> 
> 
> > > +          CPU(N) / Codec(M) DAIs were not same in one dai-link. ch-map-idx is not needed if the
> > > +          numbers were 1:M or N:1 or N=M. see soc.h::[dai_link->ch_maps Image sample] and
> > 
> > Again, relying on header files in an operating system to explain the
> > property is not a runner. You need to explain how to populate this
> > property in an operating system independent manner.
> 
> Sample is not mandatory here, I will remove Linux header pointer from here in v6.

Please don't just remove the reference to the header file, and actually
explain the property instead.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-10-24 15:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23  5:35 [PATCH v5 0/5] ASoC: makes CPU/Codec channel connection map more generic Kuninori Morimoto
2023-10-23  5:35 ` [PATCH v5 1/5] " Kuninori Morimoto
2023-10-24 14:24   ` Pierre-Louis Bossart
2023-10-24 23:11     ` Kuninori Morimoto
2023-10-23  5:35 ` [PATCH v5 2/5] ASoC: audio-graph-card2: add CPU:Codec = N:M support Kuninori Morimoto
2023-10-23  5:35 ` [PATCH v5 3/5] ASoC: audio-graph-card2-custom-sample: tidyup comment / numbering Kuninori Morimoto
2023-10-23  5:36 ` [PATCH v5 4/5] ASoC: audio-graph-card2-custom-sample: add CPU/Codec = N:M sample Kuninori Morimoto
2023-10-23  5:36 ` [PATCH v5 5/5] dt-bindings: audio-graph-port: add ch-map-idx property Kuninori Morimoto
2023-10-23 16:50   ` Conor Dooley
2023-10-23 18:47     ` Mark Brown
2023-10-24 15:27       ` Conor Dooley
2023-10-25  1:14         ` Kuninori Morimoto
2023-10-23 22:58     ` Kuninori Morimoto
2023-10-24 15:28       ` Conor Dooley [this message]
2023-10-24 22:56         ` Kuninori Morimoto
2023-10-24 20:24   ` Rob Herring
2023-10-24 23:06     ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231024-preheated-parasail-34d75ee63244@spud \
    --to=conor@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bard.liao@intel.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=robh+dt@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox