From: Raymond Hackley <raymondhackley@protonmail.com>
To: krzysztof.kozlowski@linaro.org
Cc: alim.akhtar@samsung.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, raymondhackley@protonmail.com,
robh+dt@kernel.org, ~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 1/2] ARM: dts: samsung: exynos4412-midas: fix key-ok event code
Date: Tue, 24 Oct 2023 12:37:26 +0000 [thread overview]
Message-ID: <20231024123415.2009-1-raymondhackley@protonmail.com> (raw)
In-Reply-To: <bc5bbf47-7bcb-4fc6-a88b-b92d74803a7a@linaro.org>
Hi Krzysztof,
This key-ok is the hardware middle button on midas, and there is also
touchkey, which already provides <KEY_BACK KEY_MENU>, so I assume the other
KEY_MENU in key-ok is duplicated. Fixing it with KEY_OK as the node name
implies would make more sense.
Regards,
Raymond
next prev parent reply other threads:[~2023-10-24 12:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 10:16 [PATCH v2 0/2] ARM: dts: samsung: exynos4412-midas: fix key-ok and use Linux event codes Raymond Hackley
2023-10-17 10:18 ` [PATCH v2 1/2] ARM: dts: samsung: exynos4412-midas: fix key-ok event code Raymond Hackley
2023-10-23 16:51 ` Krzysztof Kozlowski
2023-10-24 12:37 ` Raymond Hackley [this message]
2023-10-24 13:22 ` Krzysztof Kozlowski
2023-10-17 10:18 ` [PATCH v2 2/2] ARM: dts: samsung: exynos4412-midas: use Linux event codes for input keys Raymond Hackley
2023-10-18 6:24 ` [PATCH v2 0/2] ARM: dts: samsung: exynos4412-midas: fix key-ok and use Linux event codes Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024123415.2009-1-raymondhackley@protonmail.com \
--to=raymondhackley@protonmail.com \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).