From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Ramona Gradinariu <ramona.gradinariu@analog.com>,
<jic23@kernel.org>, <nuno.sa@analog.com>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 3/3] dt-bindings: adis16460: Add 'spi-cs-inactive-delay-ns' property
Date: Tue, 24 Oct 2023 13:27:05 +0100 [thread overview]
Message-ID: <20231024132705.00003cf4@Huawei.com> (raw)
In-Reply-To: <b7011f02-a412-4642-862d-c2df88ae316b@linaro.org>
On Mon, 23 Oct 2023 15:22:30 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 23/10/2023 14:35, Ramona Gradinariu wrote:
> > Add 'spi-cs-inactive-delay-ns' property.
>
> This we see from the diff. Commit should explain: Why?
>
> >
> > Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com>
> > ---
> > Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > index 4e43c80e5119..3691c0be4f9d 100644
> > --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > @@ -25,6 +25,11 @@ properties:
> >
> > spi-cpol: true
> >
> > + spi-cs-inactive-delay-ns:
> > + minimum: 16000
> > + description:
> > + If not explicitly set in the device tree, the driver will set it to 16us.
>
> Why do you even need it here?
Along side that, if you have a default
default: xxxx
rather than in the description.
>
> Best regards,
> Krzysztof
>
>
next prev parent reply other threads:[~2023-10-24 12:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 12:35 [PATCH 0/3] iio: imu: adis: Use spi cs inactive delay Ramona Gradinariu
2023-10-23 12:35 ` [PATCH 1/3] " Ramona Gradinariu
2023-10-23 12:35 ` [PATCH 2/3] dt-bindings: adis16475: Add 'spi-cs-inactive-delay-ns' property Ramona Gradinariu
2023-10-23 13:21 ` Krzysztof Kozlowski
2023-10-23 12:35 ` [PATCH 3/3] dt-bindings: adis16460: " Ramona Gradinariu
2023-10-23 13:22 ` Krzysztof Kozlowski
2023-10-24 12:27 ` Jonathan Cameron [this message]
2023-10-27 13:57 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024132705.00003cf4@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=ramona.gradinariu@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).