devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"Pali Rohár" <pali@kernel.org>,
	"Enrico Mioso" <mrkiko.rs@gmail.com>,
	"Robert Marko" <robert.marko@sartura.hr>,
	"Russell King" <linux@armlinux.org.uk>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Gregory Clement" <gregory.clement@bootlin.com>,
	"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Marek Behún" <kabel@kernel.org>,
	"Christian Marangi" <ansuelsmth@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v7 5/7] ARM64: dts: marvell: Fix some common switch mistakes
Date: Tue, 24 Oct 2023 23:20:09 +0300	[thread overview]
Message-ID: <20231024202009.mq7fu7zetc3nfyum@skbuf> (raw)
In-Reply-To: <1dff08d1-339b-4d5a-9dd4-6a6daca1dbde@alliedtelesis.co.nz>

Hello Chris,

On Tue, Oct 24, 2023 at 08:10:14PM +0000, Chris Packham wrote:
> > Chris, does this look okay?
> 
> There's nothing in the u-boot code for the CN9130-CRB that cares about 
> the switch so I don't think there's any issue ABI wise. We are working 
> on our own CN9130 based router with a L2 switch but it's at a point we 
> can follow whatever upstream decide is the final schema.

Thank you for taking the time to confirm.

> In terms of my personal preference the schema quoted up thread has the 
> pattern  '^(ethernet-)?switch(@.*)?$' (i.e. the 'ethernet-' part is 
> optional) so I'd personally prefer switch0@6 -> switch@6 but that's only 
> a slight preference because I deal with Ethernet switches day in day out.

The movement originally came from "ports" to "ethernet-ports" at Rob's
suggestion, because of the name clash with the ports from graph.yaml.
Then we also did "switch" -> "ethernet-switch" because you'll also find
"pcie-switch" in mainline device trees.

  reply	other threads:[~2023-10-24 20:20 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24 13:20 [PATCH net-next v7 0/7] Create a binding for the Marvell MV88E6xxx DSA switches Linus Walleij
2023-10-24 13:20 ` [PATCH net-next v7 1/7] dt-bindings: net: dsa: Require ports or ethernet-ports Linus Walleij
2023-10-24 16:34   ` Florian Fainelli
2023-10-25 13:02   ` Krzysztof Kozlowski
2023-10-24 13:20 ` [PATCH net-next v7 2/7] dt-bindings: net: mvusb: Fix up DSA example Linus Walleij
2023-10-24 16:34   ` Florian Fainelli
2023-10-24 13:20 ` [PATCH net-next v7 3/7] ARM: dts: marvell: Fix some common switch mistakes Linus Walleij
2023-10-24 16:35   ` Florian Fainelli
2023-10-24 13:20 ` [PATCH net-next v7 4/7] ARM: dts: nxp: " Linus Walleij
2023-10-24 16:36   ` Florian Fainelli
2023-10-24 13:20 ` [PATCH net-next v7 5/7] ARM64: dts: marvell: " Linus Walleij
2023-10-24 16:37   ` Florian Fainelli
2023-10-24 18:28   ` Vladimir Oltean
2023-10-24 19:03     ` Russell King (Oracle)
2023-10-24 19:51       ` Vladimir Oltean
2023-10-25 19:52       ` Linus Walleij
2023-10-24 20:10     ` Chris Packham
2023-10-24 20:20       ` Vladimir Oltean [this message]
2023-10-25 19:48     ` Linus Walleij
2023-10-25 20:56       ` Linus Walleij
2023-10-25 21:21         ` Andrew Lunn
2023-10-24 13:20 ` [PATCH net-next v7 6/7] dt-bindings: marvell: Rewrite MV88E6xxx in schema Linus Walleij
2023-10-24 16:39   ` Florian Fainelli
2023-10-24 13:20 ` [PATCH net-next v7 7/7] dt-bindings: marvell: Add Marvell MV88E6060 DSA schema Linus Walleij
2023-10-24 16:40   ` Florian Fainelli
2023-10-25  9:30 ` [PATCH net-next v7 0/7] Create a binding for the Marvell MV88E6xxx DSA switches patchwork-bot+netdevbpf
2023-10-25  9:36   ` Vladimir Oltean
2023-10-25 14:29     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231024202009.mq7fu7zetc3nfyum@skbuf \
    --to=olteanv@gmail.com \
    --cc=Chris.Packham@alliedtelesis.co.nz \
    --cc=andrew@lunn.ch \
    --cc=ansuelsmth@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregory.clement@bootlin.com \
    --cc=kabel@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mrkiko.rs@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pali@kernel.org \
    --cc=robert.marko@sartura.hr \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).