From: Conor Dooley <conor@kernel.org>
To: Richard Leitner <richard.leitner@linux.dev>
Cc: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: hwmon: add ti,ina238
Date: Wed, 25 Oct 2023 15:00:01 +0100 [thread overview]
Message-ID: <20231025-hut-omnivore-f4b44a7b928d@spud> (raw)
In-Reply-To: <20231025-ina237-v1-2-a0196119720c@linux.dev>
[-- Attachment #1: Type: text/plain, Size: 2461 bytes --]
On Wed, Oct 25, 2023 at 10:34:12AM +0000, Richard Leitner wrote:
> The ina238 driver is available since 2021 but lacks a dt-bindings file.
> Therefore add the missing file now.
Seemingly it is documented in Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
Cheers,
Conor.
>
> Mention Jean Delvare and Guenter Roeck as maintainers as reported by the
> get_maintainer.pl script.
>
> Signed-off-by: Richard Leitner <richard.leitner@linux.dev>
> ---
> .../devicetree/bindings/hwmon/ti,ina238.yaml | 46 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 47 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina238.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina238.yaml
> new file mode 100644
> index 000000000000..aba89e5f34b3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina238.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/ti,ina238.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments INA238 power/voltage monitors
> +
> +maintainers:
> + - Jean Delvare <jdelvare@suse.com>
> + - Guenter Roeck <linux@roeck-us.net>
> +
> +description: |
> + The INA238 is an ultra-precise digital power monitor with a
> + 16-bit delta-sigma ADC specifically designed for current-sensing
> + applications.
> +
> + Datasheets:
> + https://www.ti.com/lit/ds/symlink/ina238.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - ti,ina238
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + power-sensor@40 {
> + compatible = "ti,ina238";
> + reg = <0x40>;
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 28f91c8a2e1c..13858bd6a3d4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10271,6 +10271,7 @@ INA238 HARDWARE MONITOR DRIVER
> M: Guenter Roeck <linux@roeck-us.net>
> L: linux-hwmon@vger.kernel.org
> S: Maintained
> +F: Documentation/devicetree/bindings/hwmon/ti,ina238.yaml
> F: drivers/hwmon/ina238.c
>
> INDEX OF FURTHER KERNEL DOCUMENTATION
>
> --
> 2.40.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-10-25 14:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 10:34 [PATCH 0/4] hwmon: add ti,ina237 support to ina238 driver Richard Leitner
2023-10-25 10:34 ` [PATCH 1/4] MAINTAINERS: Add entry for " Richard Leitner
2023-10-26 1:03 ` Guenter Roeck
2023-10-26 6:46 ` Richard Leitner
2023-10-25 10:34 ` [PATCH 2/4] dt-bindings: hwmon: add ti,ina238 Richard Leitner
2023-10-25 14:00 ` Conor Dooley [this message]
2023-10-25 14:07 ` Richard Leitner
2023-10-25 14:11 ` Conor Dooley
2023-10-25 14:18 ` Krzysztof Kozlowski
2023-10-25 14:23 ` Richard Leitner
2023-10-25 14:27 ` Krzysztof Kozlowski
2023-10-25 14:32 ` Richard Leitner
2023-10-25 15:26 ` Krzysztof Kozlowski
2023-10-25 14:25 ` Conor Dooley
2023-10-25 14:28 ` Krzysztof Kozlowski
2023-10-25 10:34 ` [PATCH 3/4] hwmon: ina238: add ina237 support Richard Leitner
2023-10-25 10:34 ` [PATCH 4/4] dt-bindings: hwmon: ti,ina238: add ti,ina237 Richard Leitner
2023-10-25 13:58 ` Conor Dooley
2023-10-25 14:13 ` Richard Leitner
2023-10-25 14:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025-hut-omnivore-f4b44a7b928d@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=richard.leitner@linux.dev \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).