From: Richard Leitner <richard.leitner@linux.dev>
To: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org,
Richard Leitner <richard.leitner@linux.dev>
Subject: [PATCH 3/4] hwmon: ina238: add ina237 support
Date: Wed, 25 Oct 2023 10:34:13 +0000 [thread overview]
Message-ID: <20231025-ina237-v1-3-a0196119720c@linux.dev> (raw)
In-Reply-To: <20231025-ina237-v1-0-a0196119720c@linux.dev>
The INA237 "85-V, 16-Bit, Precision Power Monitor With I2C Interface" is
basically the same as INA328. Therefore add a corresponding compatible
to the driver.
According to the datasheet the main difference is the current and power
monitoring accuracy:
+------------------------+---------------+---------------+
| | INA238 | INA237 |
+------------------------+---------------+---------------+
| Offset voltage | +/- 5µV | +/- 50µV |
| Offset drift | +/- 0.02µV/°C | +/- 0.02µV/°C |
| Gain error | +/- 0.1% | +/- 0.3% |
| Gain error drift | +/- 25ppm/°C | +/- 50ppm/°C |
| Common mode rejection | 140dB | 120dB |
| Power accuracy | 0.7% | 1.6% |
+------------------------+---------------+---------------+
As well as the missing DEVICE_ID register at 0x3F, which is currently
not in use by the driver.
Signed-off-by: Richard Leitner <richard.leitner@linux.dev>
---
drivers/hwmon/ina238.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hwmon/ina238.c b/drivers/hwmon/ina238.c
index f519c22d3907..ca9f5d2c811b 100644
--- a/drivers/hwmon/ina238.c
+++ b/drivers/hwmon/ina238.c
@@ -33,7 +33,7 @@
#define INA238_BUS_UNDER_VOLTAGE 0xf
#define INA238_TEMP_LIMIT 0x10
#define INA238_POWER_LIMIT 0x11
-#define INA238_DEVICE_ID 0x3f
+#define INA238_DEVICE_ID 0x3f /* not available on INA237 */
#define INA238_CONFIG_ADCRANGE BIT(4)
@@ -622,6 +622,7 @@ static const struct i2c_device_id ina238_id[] = {
MODULE_DEVICE_TABLE(i2c, ina238_id);
static const struct of_device_id __maybe_unused ina238_of_match[] = {
+ { .compatible = "ti,ina237" },
{ .compatible = "ti,ina238" },
{ },
};
--
2.40.1
next prev parent reply other threads:[~2023-10-25 10:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 10:34 [PATCH 0/4] hwmon: add ti,ina237 support to ina238 driver Richard Leitner
2023-10-25 10:34 ` [PATCH 1/4] MAINTAINERS: Add entry for " Richard Leitner
2023-10-26 1:03 ` Guenter Roeck
2023-10-26 6:46 ` Richard Leitner
2023-10-25 10:34 ` [PATCH 2/4] dt-bindings: hwmon: add ti,ina238 Richard Leitner
2023-10-25 14:00 ` Conor Dooley
2023-10-25 14:07 ` Richard Leitner
2023-10-25 14:11 ` Conor Dooley
2023-10-25 14:18 ` Krzysztof Kozlowski
2023-10-25 14:23 ` Richard Leitner
2023-10-25 14:27 ` Krzysztof Kozlowski
2023-10-25 14:32 ` Richard Leitner
2023-10-25 15:26 ` Krzysztof Kozlowski
2023-10-25 14:25 ` Conor Dooley
2023-10-25 14:28 ` Krzysztof Kozlowski
2023-10-25 10:34 ` Richard Leitner [this message]
2023-10-25 10:34 ` [PATCH 4/4] dt-bindings: hwmon: ti,ina238: add ti,ina237 Richard Leitner
2023-10-25 13:58 ` Conor Dooley
2023-10-25 14:13 ` Richard Leitner
2023-10-25 14:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025-ina237-v1-3-a0196119720c@linux.dev \
--to=richard.leitner@linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).