From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24E5A2587 for ; Wed, 25 Oct 2023 09:26:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tULDT4F4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D99D1C433C8; Wed, 25 Oct 2023 09:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698226005; bh=4n0iQGryR3l11ivfAXSZJrCU7Nk2I5Jy+sv+NdwUasQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tULDT4F4BuJuij+PaCntRR4+ii5P140m7lR+dfTCphuE2Q+ux46tUY8wcaQ6uXiMb pLYWpIqLoR9/kKBHvCCvRkzTR3OGVnmxBc9TDnZkHYNEJqB0ZZPB9y5VXOCuDtB561 7PB4243yWqd+wmudvFJX/c16YrRlC+opihHGC5/SMlUkJevQCZpDCqePPdRYcGj31p JzIr9+RKEI7INPqB8H1fiChgl5cpBDZ3RL2ct7XoslhxFnwSEJ5jjWbyX676rEQLJA n6jYty+uYu4cQ5gYBLp2h18fOBAZnPgC/CmwiXq2VateWeAW0vdbpIT3/c5AFUbanw 6EwJxQVsC8z3Q== Date: Wed, 25 Oct 2023 10:26:39 +0100 From: Lee Jones To: Jeff LaBundy Cc: James Ogletree , James Ogletree , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Fred Treven , Ben Bright , "linux-input@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 3/4] mfd: cs40l50: Add support for CS40L50 core driver Message-ID: <20231025092639.GL8909@google.com> References: <20231018175726.3879955-1-james.ogletree@opensource.cirrus.com> <20231018175726.3879955-4-james.ogletree@opensource.cirrus.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, 24 Oct 2023, Jeff LaBundy wrote: > Hi James, > > Just a few trailing comments on top of Lee's feedback. > > On Wed, Oct 18, 2023 at 05:57:24PM +0000, James Ogletree wrote: > > From: James Ogletree > > > > Introduce support for Cirrus Logic Device CS40L50: a > > haptic driver with waveform memory, integrated DSP, > > and closed-loop algorithms. > > > > The MFD component registers and initializes the device. > > > > Signed-off-by: James Ogletree > > --- > > MAINTAINERS | 2 + > > drivers/mfd/Kconfig | 30 +++ > > drivers/mfd/Makefile | 4 + > > drivers/mfd/cs40l50-core.c | 443 ++++++++++++++++++++++++++++++++++++ > > drivers/mfd/cs40l50-i2c.c | 69 ++++++ > > drivers/mfd/cs40l50-spi.c | 68 ++++++ > > include/linux/mfd/cs40l50.h | 198 ++++++++++++++++ > > 7 files changed, 814 insertions(+) > > create mode 100644 drivers/mfd/cs40l50-core.c > > create mode 100644 drivers/mfd/cs40l50-i2c.c > > create mode 100644 drivers/mfd/cs40l50-spi.c > > create mode 100644 include/linux/mfd/cs40l50.h Just popping along to say; these are excellent comments Jeff. Thank you for your review. -- Lee Jones [李琼斯]