devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	kernel@pengutronix.de
Subject: Re: [PATCH v3 4/7] regulator: dt-bindings: whitelist system-critical-regulator property for fixed-regulator
Date: Thu, 26 Oct 2023 09:10:32 +0200	[thread overview]
Message-ID: <20231026071032.GI3803936@pengutronix.de> (raw)
In-Reply-To: <e2ae68a5-b6fc-4b0f-b198-e635435c33ce@sirena.org.uk>

On Wed, Oct 25, 2023 at 01:41:45PM +0100, Mark Brown wrote:
> On Wed, Oct 25, 2023 at 10:46:11AM +0200, Oleksij Rempel wrote:
> > Allow fixed-regulator to be marked as system-critical by whitelisting
> > the 'system-critical-regulator' property.
> > 
> > This property indicating that the fixed-regulator is critical to system
> > stability or functionality, aligning with the recent changes in the
> > regulator core handling of under-voltage events for system-critical
> > regulators.
> 
> Why would this need to be something we explicitly enable for a given
> regulator?  Surely this is a property of the creativity of hardware
> engineers rather than the regulator itself.

:)

> Also please avoid the use of the outdated terms whitelist and blacklist,
> pass and block lists are often a good alternative.

ack

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2023-10-26  7:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-25  8:46 [PATCH v3 0/7] regulator: add under-voltage support Oleksij Rempel
2023-10-25  8:46 ` [PATCH v3 1/7] regulator: dt-bindings: Add system-critical-regulator property Oleksij Rempel
2023-10-25  8:46 ` [PATCH v3 2/7] regulator: Handle system-critical under-voltage events Oleksij Rempel
2023-10-25 12:47   ` Mark Brown
2023-10-25  8:46 ` [PATCH v3 3/7] regulator: dt-bindings: fixed-regulator: Add under-voltage interrupt support Oleksij Rempel
2023-10-25  8:46 ` [PATCH v3 4/7] regulator: dt-bindings: whitelist system-critical-regulator property for fixed-regulator Oleksij Rempel
2023-10-25 12:41   ` Mark Brown
2023-10-26  7:10     ` Oleksij Rempel [this message]
2023-10-25  8:46 ` [PATCH v3 5/7] regulator: fixed: add support for under-voltage IRQ Oleksij Rempel
2023-10-25  8:46 ` [PATCH v3 6/7] regulator: dt-bindings: Add regulator-uv-survival-time-ms property Oleksij Rempel
2023-10-27 20:35   ` Rob Herring
2023-10-25  8:46 ` [PATCH v3 7/7] regulator: Implement uv_survival_time for handling under-voltage events Oleksij Rempel
2023-10-25 17:47 ` (subset) [PATCH v3 0/7] regulator: add under-voltage support Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231026071032.GI3803936@pengutronix.de \
    --to=o.rempel@pengutronix.de \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).