From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9737FE54E for ; Thu, 26 Oct 2023 07:10:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBAD018D for ; Thu, 26 Oct 2023 00:10:34 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qvuVl-0006p3-17; Thu, 26 Oct 2023 09:10:33 +0200 Received: from [2a0a:edc0:2:b01:1d::c0] (helo=ptx.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qvuVk-004Lmo-CY; Thu, 26 Oct 2023 09:10:32 +0200 Received: from ore by ptx.whiteo.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1qvuVk-00GPNi-9w; Thu, 26 Oct 2023 09:10:32 +0200 Date: Thu, 26 Oct 2023 09:10:32 +0200 From: Oleksij Rempel To: Mark Brown Cc: devicetree@vger.kernel.org, Conor Dooley , Krzysztof Kozlowski , Liam Girdwood , linux-kernel@vger.kernel.org, Rob Herring , kernel@pengutronix.de Subject: Re: [PATCH v3 4/7] regulator: dt-bindings: whitelist system-critical-regulator property for fixed-regulator Message-ID: <20231026071032.GI3803936@pengutronix.de> References: <20231025084614.3092295-1-o.rempel@pengutronix.de> <20231025084614.3092295-5-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org On Wed, Oct 25, 2023 at 01:41:45PM +0100, Mark Brown wrote: > On Wed, Oct 25, 2023 at 10:46:11AM +0200, Oleksij Rempel wrote: > > Allow fixed-regulator to be marked as system-critical by whitelisting > > the 'system-critical-regulator' property. > > > > This property indicating that the fixed-regulator is critical to system > > stability or functionality, aligning with the recent changes in the > > regulator core handling of under-voltage events for system-critical > > regulators. > > Why would this need to be something we explicitly enable for a given > regulator? Surely this is a property of the creativity of hardware > engineers rather than the regulator itself. :) > Also please avoid the use of the outdated terms whitelist and blacklist, > pass and block lists are often a good alternative. ack -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |