From: Herve Codina <herve.codina@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] of: address: Consolidate bus .map() functions
Date: Thu, 26 Oct 2023 16:24:38 +0200 [thread overview]
Message-ID: <20231026162438.5b063044@bootlin.com> (raw)
In-Reply-To: <20231026135358.3564307-3-robh@kernel.org>
Hi Rob,
On Thu, 26 Oct 2023 08:53:59 -0500
Rob Herring <robh@kernel.org> wrote:
> The bus .map() functions vary only by checking the flag cells values
> and skipping over any flag cells to read the addresses. Otherwise they
> all do the same reading 'ranges' address and size and returning the
> address's offset if it is within the 'ranges' entry.
>
> Refactor all the .map() functions to pass in the flag cell size so that
> each bus can check the bus specific flags and then call a common
> function to do everything else.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Herve Codina <herve.codina@bootlin.com>
Best regards,
Hervé
next prev parent reply other threads:[~2023-10-26 14:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 13:53 [PATCH 1/2] of: address: Store number of bus flag cells rather than bool Rob Herring
2023-10-26 13:53 ` [PATCH 2/2] of: address: Consolidate bus .map() functions Rob Herring
2023-10-26 14:24 ` Herve Codina [this message]
2023-10-26 14:15 ` [PATCH 1/2] of: address: Store number of bus flag cells rather than bool Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231026162438.5b063044@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).