From: Conor Dooley <conor@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Elad Nachman <enachman@marvell.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com,
sebastian.hesselbarth@gmail.com, pali@kernel.org,
mrkiko.rs@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, cyuval@marvell.com
Subject: Re: [PATCH v3 2/3] dt-bindings: arm64: dts: add dt-bindings for ac5x rd carrier
Date: Fri, 27 Oct 2023 15:19:40 +0100 [thread overview]
Message-ID: <20231027-opposite-frostily-b41eb861c8a1@spud> (raw)
In-Reply-To: <1075eedc-3e7e-4070-8cf2-ae63513fd764@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1429 bytes --]
On Fri, Oct 27, 2023 at 01:09:58PM +0200, Krzysztof Kozlowski wrote:
> On 26/10/2023 10:47, Elad Nachman wrote:
> > From: Elad Nachman <enachman@marvell.com>
> >
> > Add dt bindings for AC5X RD COM Express Type 7 carrier board.
> > This board will Accept a CN9131 COM Express Type 7 CPU module.
> >
> > Signed-off-by: Elad Nachman <enachman@marvell.com>
> > ---
> > .../devicetree/bindings/arm/marvell/armada-7k-8k.yaml | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> > index 52d78521e412..71bc94047d1b 100644
> > --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> > @@ -60,4 +60,12 @@ properties:
> > - const: marvell,armada-ap807-quad
> > - const: marvell,armada-ap807
> >
> > + - description: AC5X RD COM Express Carrier for Armada CN9131 SoC with one external CP
> > + items:
> > + - const: marvell,ac5x_rd_carrier
>
> No underscores in compatibles.
Oh shit, I didn't notice that somehow. Un-acked until that's removed.
> Do you see them anywhere? Please use
> existing, recent code as start of your contributions, not something
> buggy 5 years old.
>
> Best regards,
> Krzysztof
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-10-27 14:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 8:47 [PATCH v3 0/3] arm64: dts: cn913x: add device trees for COM Express boards Elad Nachman
2023-10-26 8:47 ` [PATCH v3 1/3] " Elad Nachman
2023-10-26 17:32 ` Andrew Lunn
2023-10-27 11:12 ` Krzysztof Kozlowski
2023-10-26 8:47 ` [PATCH v3 2/3] dt-bindings: arm64: dts: add dt-bindings for ac5x rd carrier Elad Nachman
2023-10-26 14:08 ` Conor Dooley
2023-10-26 17:44 ` Andrew Lunn
2023-10-27 11:09 ` Krzysztof Kozlowski
2023-10-27 14:19 ` Conor Dooley [this message]
2023-10-27 14:29 ` Andrew Lunn
2023-10-27 11:15 ` Krzysztof Kozlowski
2023-10-26 8:47 ` [PATCH v3 3/3] MAINTAINERS: add ac5 to list of maintained Marvell dts files Elad Nachman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231027-opposite-frostily-b41eb861c8a1@spud \
--to=conor@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=cyuval@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=enachman@marvell.com \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mrkiko.rs@gmail.com \
--cc=pali@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).