* [PATCH 1/1] of: unittest: Fix test build on config without CONFIG_OF_ADDRESS
@ 2023-10-27 10:24 Herve Codina
2023-10-27 21:38 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Herve Codina @ 2023-10-27 10:24 UTC (permalink / raw)
To: Rob Herring, Frank Rowand, Lizhi Hou
Cc: Max Zhen, Sonal Santan, Stefano Stabellini, Jonathan Cameron,
Bjorn Helgaas, devicetree, linux-kernel, Allan Nielsen,
Horatiu Vultur, Steen Hegelund, Thomas Petazzoni, Herve Codina,
kernel test robot
of_address_to_resource() is not defined if !CONFIG_OF_ADDRESS.
Return early in of_unittest_check_addr() to avoid the
of_address_to_resource() usage.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310271513.8MUErCK4-lkp@intel.com/
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
Rob,
This fixes a patch you already applied from my series
https://lore.kernel.org/all/20231017110221.189299-1-herve.codina@bootlin.com/
I don't know if it's too late or not but maybe you can squash this fix patch.
My apologies for this issue.
Hervé
drivers/of/unittest.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index ffbecd349899..e9e90e96600e 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -1201,6 +1201,9 @@ static void __init of_unittest_check_addr(const char *node_path,
unsigned int count;
int ret;
+ if (!IS_ENABLED(CONFIG_OF_ADDRESS))
+ return;
+
np = of_find_node_by_path(node_path);
if (!np) {
pr_err("missing testcase data (%s)\n", node_path);
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] of: unittest: Fix test build on config without CONFIG_OF_ADDRESS
2023-10-27 10:24 [PATCH 1/1] of: unittest: Fix test build on config without CONFIG_OF_ADDRESS Herve Codina
@ 2023-10-27 21:38 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2023-10-27 21:38 UTC (permalink / raw)
To: Herve Codina
Cc: Sonal Santan, Jonathan Cameron, linux-kernel, Rob Herring,
Allan Nielsen, Max Zhen, Stefano Stabellini, Horatiu Vultur,
Lizhi Hou, Steen Hegelund, Bjorn Helgaas, Frank Rowand,
devicetree, kernel test robot, Thomas Petazzoni
On Fri, 27 Oct 2023 12:24:37 +0200, Herve Codina wrote:
> of_address_to_resource() is not defined if !CONFIG_OF_ADDRESS.
>
> Return early in of_unittest_check_addr() to avoid the
> of_address_to_resource() usage.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310271513.8MUErCK4-lkp@intel.com/
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> ---
> Rob,
>
> This fixes a patch you already applied from my series
> https://lore.kernel.org/all/20231017110221.189299-1-herve.codina@bootlin.com/
>
> I don't know if it's too late or not but maybe you can squash this fix patch.
>
> My apologies for this issue.
>
> Hervé
>
> drivers/of/unittest.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Squashed and applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-27 21:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-27 10:24 [PATCH 1/1] of: unittest: Fix test build on config without CONFIG_OF_ADDRESS Herve Codina
2023-10-27 21:38 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).