From: Manivannan Sadhasivam <mani@kernel.org>
To: Mrinmay Sarkar <quic_msarkar@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
konrad.dybcio@linaro.org, mani@kernel.org, robh+dt@kernel.org,
quic_shazhuss@quicinc.com, quic_nitegupt@quicinc.com,
quic_ramkri@quicinc.com, quic_nayiluri@quicinc.com,
dmitry.baryshkov@linaro.org, robh@kernel.org,
quic_krichai@quicinc.com, quic_vbadigan@quicinc.com,
quic_parass@quicinc.com, quic_schintav@quicinc.com,
quic_shijjose@quicinc.com,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v1 0/3] arm64: qcom: sa8775p: add cache coherency support for SA8775P
Date: Tue, 31 Oct 2023 22:27:47 +0530 [thread overview]
Message-ID: <20231031165747.GF11778@thinkpad> (raw)
In-Reply-To: <1698767186-5046-1-git-send-email-quic_msarkar@quicinc.com>
On Tue, Oct 31, 2023 at 09:16:23PM +0530, Mrinmay Sarkar wrote:
> This series is to enable cache snooping logic in both RC and EP
> driver and add the "dma-coherent" property in dtsi to support
> cache coherency in SA8775P.
>
You need to explain why cache snooping needs to be enabled _only_ on SA8775P and
not on other platforms, here and also in patch description.
Cover letter is not just meant for describing the changes you are submitting,
you should also put as much info required for the reviewers/maintainers to get
motivation behind the series.
- Mani
> To verify this series we required [1]
>
> [1] https://lore.kernel.org/all/1698729108-27356-1-git-send-email-quic_msarkar@quicinc.com/
>
> Mrinmay Sarkar (3):
> PCI: qcom: Enable cache coherency for SA8775P RC
> PCI: qcom-ep: Enable cache coherency for SA8775P EP
> arm64: dts: qcom: sa8775p: Mark PCIe controller as cache coherent
>
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 ++
> drivers/pci/controller/dwc/pcie-qcom-ep.c | 8 ++++++++
> drivers/pci/controller/dwc/pcie-qcom.c | 11 +++++++++++
> 3 files changed, 21 insertions(+)
>
> --
> 2.7.4
>
--
மணிவண்ணன் சதாசிவம்
prev parent reply other threads:[~2023-10-31 16:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 15:46 [PATCH v1 0/3] arm64: qcom: sa8775p: add cache coherency support for SA8775P Mrinmay Sarkar
2023-10-31 15:46 ` [PATCH v1 1/3] PCI: qcom: Enable cache coherency for SA8775P RC Mrinmay Sarkar
2023-10-31 16:50 ` Konrad Dybcio
2023-11-02 10:16 ` Mrinmay Sarkar
2023-11-02 22:27 ` Konrad Dybcio
2023-11-02 15:34 ` Dmitry Baryshkov
2023-11-02 16:36 ` Manivannan Sadhasivam
2023-11-02 22:25 ` Konrad Dybcio
2023-11-03 7:58 ` Manivannan Sadhasivam
2023-11-06 7:19 ` Mrinmay Sarkar
2023-10-31 15:46 ` [PATCH v1 2/3] PCI: qcom-ep: Enable cache coherency for SA8775P EP Mrinmay Sarkar
2023-10-31 16:50 ` Konrad Dybcio
2023-10-31 15:46 ` [PATCH v1 3/3] arm64: dts: qcom: sa8775p: Mark PCIe controller as cache coherent Mrinmay Sarkar
2023-10-31 16:57 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231031165747.GF11778@thinkpad \
--to=mani@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=quic_krichai@quicinc.com \
--cc=quic_msarkar@quicinc.com \
--cc=quic_nayiluri@quicinc.com \
--cc=quic_nitegupt@quicinc.com \
--cc=quic_parass@quicinc.com \
--cc=quic_ramkri@quicinc.com \
--cc=quic_schintav@quicinc.com \
--cc=quic_shazhuss@quicinc.com \
--cc=quic_shijjose@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).