* [PATCH v5 0/3] media: i2c: Add driver for THine THP7312 ISP
@ 2023-10-30 13:32 Laurent Pinchart
2023-10-30 13:32 ` [PATCH v5 1/3] dt-bindings: media: Add bindings " Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2023-10-30 13:32 UTC (permalink / raw)
To: linux-media
Cc: Paul Elder, Hans Verkuil, Matthias Brugger,
AngeloGioacchino Del Regno, Julien Stephan, Sakari Ailus,
linux-mediatek, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree
Hello,
This patch series adds a new driver for the THine THP7312 ISP. It has
been tested on an OLogic Pumpkin i350, which has a Mediatek MT8365 SoC,
with the THine THSCG101 camera module.
Technically the driver itself (and its bindings) have no dependencies,
but to run/test this on the Pumpkin i350 with the mainline kernel, a
number of patches are needed to support the board and the MT8365 SoC.
Some of those patches are on their way to mainline, and some, like the
Pumpkin i350 board device tree, will require more work. For convenience
and reference, the needed patches are available in [1].
[1] https://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git/log/?h=mtk/v6.6/pumpkin/camera
Example overlays for DT integration of the THP7312 are available in that
branch, in
arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi0-thp7312-imx258.dtso and
arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi1-thp7312-imx258.dtso.
Compared to v4, lots of small fixes and improvements to the driver have
found their way in 3/3, as well as a small update to the DT bindings in
1/3. Please see the patches for detailed changelogs. The series has also
been rebased on top of the latest Linux media master branch, and tested
on v6.6.
Below is the mandatory v4l2-compliance report. Careful readers may
notice that my v4l2-utils version is three commits behind upstream, but
that makes no practical difference as those commits are not related to
v4l2-compliance.
v4l2-compliance 1.25.0-5097, 64 bits, 64-bit time_t
v4l2-compliance SHA: b79e00a74fde 2023-09-13 07:19:23
Compliance test for device /dev/v4l-subdev2:
Driver Info:
Driver version : 6.6.0
Capabilities : 0x00000000
Required ioctls:
test VIDIOC_SUDBEV_QUERYCAP: OK
test invalid ioctls: OK
Allow for multiple opens:
test second /dev/v4l-subdev2 open: OK
test VIDIOC_SUBDEV_QUERYCAP: OK
test for unlimited opens: OK
Debug ioctls:
[ 828.412128] thp7312 2-0061: ================= START STATUS =================
[ 828.413148] thp7312 2-0061: Focus, Automatic Continuous: true
[ 828.414058] thp7312 2-0061: Focus, Absolute: 0
[ 828.414680] thp7312 2-0061: Auto-Focus Method: 2
[ 828.415310] thp7312 2-0061: White Balance, Automatic: true
[ 828.416050] thp7312 2-0061: Red Balance: 64
[ 828.416630] thp7312 2-0061: Blue Balance: 50
[ 828.417291] thp7312 2-0061: Brightness: 0
[ 828.417854] thp7312 2-0061: Saturation: 10
[ 828.418419] thp7312 2-0061: Contrast: 10
[ 828.418957] thp7312 2-0061: Sharpness: 8
[ 828.419499] thp7312 2-0061: Horizontal Flip: false
[ 828.420146] thp7312 2-0061: Vertical Flip: false
[ 828.420767] thp7312 2-0061: Auto Exposure, Bias: 0
[ 828.421465] thp7312 2-0061: Power Line Frequency: 50 Hz
[ 828.422179] thp7312 2-0061: Link Frequency: 387500000
[ 828.422860] thp7312 2-0061: Camera Orientation: Front
[ 828.423523] thp7312 2-0061: Camera Sensor Rotation: 0
[ 828.424185] thp7312 2-0061: Low Light Compensation: false
[ 828.424891] thp7312 2-0061: Noise Reduction Auto: true
[ 828.425606] thp7312 2-0061: Noise Reduction Level: 0
[ 828.426270] thp7312 2-0061: ================== END STATUS ==================
test VIDIOC_LOG_STATUS: OK
Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0
Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported)
test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
test VIDIOC_ENUMAUDOUT: OK (Not Supported)
test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0
Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
test VIDIOC_G/S_EDID: OK (Not Supported)
Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
Standard Controls: 20 Private Controls: 4
Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK (Not Supported)
test VIDIOC_G/S_PARM: OK (Not Supported)
test VIDIOC_G_FBUF: OK (Not Supported)
test VIDIOC_G_FMT: OK (Not Supported)
test VIDIOC_TRY_FMT: OK (Not Supported)
test VIDIOC_S_FMT: OK (Not Supported)
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)
Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
test VIDIOC_G_ENC_INDEX: OK (Not Supported)
test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)
Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK (Not Supported)
test VIDIOC_EXPBUF: OK (Not Supported)
test Requests: OK (Not Supported)
Total for device /dev/v4l-subdev2: 43, Succeeded: 43, Failed: 0, Warnings: 0
Laurent Pinchart (1):
media: uapi: Add controls for the THP7312 ISP
Paul Elder (2):
dt-bindings: media: Add bindings for THine THP7312 ISP
media: i2c: Add driver for THine THP7312
.../bindings/media/i2c/thine,thp7312.yaml | 231 ++
.../userspace-api/media/drivers/index.rst | 1 +
.../userspace-api/media/drivers/thp7312.rst | 32 +
MAINTAINERS | 10 +
drivers/media/i2c/Kconfig | 16 +
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/thp7312.c | 2415 +++++++++++++++++
include/uapi/linux/thp7312.h | 19 +
include/uapi/linux/v4l2-controls.h | 6 +
9 files changed, 2731 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml
create mode 100644 Documentation/userspace-api/media/drivers/thp7312.rst
create mode 100644 drivers/media/i2c/thp7312.c
create mode 100644 include/uapi/linux/thp7312.h
base-commit: 3e238417254bfdcc23fe207780b59cbb08656762
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v5 1/3] dt-bindings: media: Add bindings for THine THP7312 ISP
2023-10-30 13:32 [PATCH v5 0/3] media: i2c: Add driver for THine THP7312 ISP Laurent Pinchart
@ 2023-10-30 13:32 ` Laurent Pinchart
2023-10-31 17:05 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2023-10-30 13:32 UTC (permalink / raw)
To: linux-media
Cc: Paul Elder, Hans Verkuil, Matthias Brugger,
AngeloGioacchino Del Regno, Julien Stephan, Sakari Ailus,
linux-mediatek, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree
From: Paul Elder <paul.elder@ideasonboard.com>
The THP7312 is an external ISP from THine. Add DT bindings for it.
Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Co-developed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes since v4:
- Add bus-type property
Changes since v2:
- Drop description of reg property
- Improve thine,boot-mode property documentation
- Making thine,boot-mode property optional
- Don't use underscores in supplies names
---
.../bindings/media/i2c/thine,thp7312.yaml | 231 ++++++++++++++++++
MAINTAINERS | 7 +
2 files changed, 238 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml
diff --git a/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml b/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml
new file mode 100644
index 000000000000..a576a8669644
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml
@@ -0,0 +1,231 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (c) 2023 Ideas on Board
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/thine,thp7312.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: THine THP7312
+
+maintainers:
+ - Paul Elder <paul.elder@@ideasonboard.com>
+
+description:
+ The THP7312 is a standalone ISP controlled over i2c, and is capable of
+ various image processing and correction functions, including 3A control. It
+ can be connected to CMOS image sensors from various vendors, supporting both
+ MIPI CSI-2 and parallel interfaces. It can also output on either MIPI CSI-2
+ or parallel. The hardware is capable of transmitting and receiving MIPI
+ interlaved data strams with data types or multiple virtual channel
+ identifiers.
+
+allOf:
+ - $ref: ../video-interface-devices.yaml#
+
+properties:
+ compatible:
+ const: thine,thp7312
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+ description: CLKI clock input
+
+ thine,boot-mode:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 0
+ maximum: 1
+ default: 1
+ description:
+ Boot mode of the THP7312, reflecting the value of the BOOT[0] pin strap.
+ 0 is for the SPI/2-wire slave boot, 1 is for the SPI master boot (from
+ external flash ROM).
+
+ reset-gpios:
+ maxItems: 1
+ description:
+ Reference to the GPIO connected to the RESET_N pin, if any.
+ Must be released (set high) after all supplies are applied.
+
+ vddcore-supply:
+ description:
+ 1.2V supply for core, PLL, MIPI rx and MIPI tx.
+
+ vhtermrx-supply:
+ description:
+ Supply for input (RX). 1.8V for MIPI, or 1.8/2.8/3.3V for parallel.
+
+ vddtx-supply:
+ description:
+ Supply for output (TX). 1.8V for MIPI, or 1.8/2.8/3.3V for parallel.
+
+ vddhost-supply:
+ description:
+ Supply for host interface. 1.8V, 2.8V, or 3.3V.
+
+ vddcmos-supply:
+ description:
+ Supply for sensor interface. 1.8V, 2.8V, or 3.3V.
+
+ vddgpio-0-supply:
+ description:
+ Supply for GPIO_0. 1.8V, 2.8V, or 3.3V.
+
+ vddgpio-1-supply:
+ description:
+ Supply for GPIO_1. 1.8V, 2.8V, or 3.3V.
+
+ orientation: true
+ rotation: true
+
+ port:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ additionalProperties: false
+
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ bus-type:
+ const: 4 # CSI-2 D-PHY
+
+ data-lanes:
+ description:
+ This property is for lane reordering between the THP7312 and the
+ SoC. The sensor supports either two-lane, or four-lane operation.
+ If this property is omitted four-lane operation is assumed. For
+ two-lane operation the property must be set to <1 2>.
+ minItems: 2
+ maxItems: 4
+ items:
+ maximum: 4
+
+ sensors:
+ type: object
+ description: List of connected sensors
+
+ properties:
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+ patternProperties:
+ "^sensor@[01]":
+ type: object
+ description:
+ Sensors connected to the first and second input, with one node per
+ sensor.
+
+ properties:
+ thine,model:
+ $ref: /schemas/types.yaml#/definitions/string
+ description:
+ Model of the connected sensors. Must be a valid compatible string.
+
+ reg:
+ maxItems: 1
+ description: THP7312 input port number
+
+ data-lanes:
+ $ref: /schemas/media/video-interfaces.yaml#/properties/data-lanes
+ items:
+ maxItems: 4
+ description:
+ This property is for lane reordering between the THP7312 and the imaging
+ sensor that it is connected to.
+
+ patternProperties:
+ ".*-supply":
+ description: Power supplies for the sensor
+
+ required:
+ - reg
+ - data-lanes
+
+ additionalProperties: false
+
+ required:
+ - "#address-cells"
+ - "#size-cells"
+
+ additionalProperties: false
+
+required:
+ - compatible
+ - reg
+ - reset-gpios
+ - clocks
+ - vddcore-supply
+ - vhtermrx-supply
+ - vddtx-supply
+ - vddhost-supply
+ - vddcmos-supply
+ - vddgpio-0-supply
+ - vddgpio-1-supply
+ - sensors
+ - port
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/media/video-interfaces.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ camera@61 {
+ compatible = "thine,thp7312";
+ reg = <0x61>;
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&cam1_pins_default>;
+
+ reset-gpios = <&pio 119 GPIO_ACTIVE_LOW>;
+ clocks = <&camera61_clk>;
+
+ vddcore-supply = <&vsys_v4p2>;
+ vhtermrx-supply = <&vsys_v4p2>;
+ vddtx-supply = <&vsys_v4p2>;
+ vddhost-supply = <&vsys_v4p2>;
+ vddcmos-supply = <&vsys_v4p2>;
+ vddgpio-0-supply = <&vsys_v4p2>;
+ vddgpio-1-supply = <&vsys_v4p2>;
+
+ orientation = <0>;
+ rotation = <0>;
+
+ sensors {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ sensor@0 {
+ thine,model = "sony,imx258";
+ reg = <0>;
+
+ data-lanes = <4 1 3 2>;
+
+ dovdd-supply = <&vsys_v4p2>;
+ avdd-supply = <&vsys_v4p2>;
+ dvdd-supply = <&vsys_v4p2>;
+ };
+ };
+
+ port {
+ thp7312_2_endpoint: endpoint {
+ remote-endpoint = <&mipi_thp7312_2>;
+ bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
+ data-lanes = <4 2 1 3>;
+ };
+ };
+ };
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index f3e6dbbbbccb..2e094a7e7d07 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -21448,6 +21448,13 @@ S: Maintained
F: Documentation/ABI/testing/sysfs-class-firmware-attributes
F: drivers/platform/x86/think-lmi.?
+THP7312 ISP DRIVER
+M: Paul Elder <paul.elder@ideasonboard.com>
+L: linux-media@vger.kernel.org
+S: Maintained
+T: git git://linuxtv.org/media_tree.git
+F: Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml
+
THUNDERBOLT DMA TRAFFIC TEST DRIVER
M: Isaac Hazan <isaac.hazan@intel.com>
L: linux-usb@vger.kernel.org
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v5 1/3] dt-bindings: media: Add bindings for THine THP7312 ISP
2023-10-30 13:32 ` [PATCH v5 1/3] dt-bindings: media: Add bindings " Laurent Pinchart
@ 2023-10-31 17:05 ` Rob Herring
2023-11-02 0:47 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2023-10-31 17:05 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-media, Paul Elder, Hans Verkuil, Matthias Brugger,
AngeloGioacchino Del Regno, Julien Stephan, Sakari Ailus,
linux-mediatek, Krzysztof Kozlowski, Conor Dooley, devicetree
On Mon, Oct 30, 2023 at 03:32:45PM +0200, Laurent Pinchart wrote:
> From: Paul Elder <paul.elder@ideasonboard.com>
>
> The THP7312 is an external ISP from THine. Add DT bindings for it.
>
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> Co-developed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Changes since v4:
>
> - Add bus-type property
>
> Changes since v2:
>
> - Drop description of reg property
> - Improve thine,boot-mode property documentation
> - Making thine,boot-mode property optional
> - Don't use underscores in supplies names
> ---
> .../bindings/media/i2c/thine,thp7312.yaml | 231 ++++++++++++++++++
> MAINTAINERS | 7 +
> 2 files changed, 238 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml b/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml
> new file mode 100644
> index 000000000000..a576a8669644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml
> @@ -0,0 +1,231 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (c) 2023 Ideas on Board
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/thine,thp7312.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: THine THP7312
> +
> +maintainers:
> + - Paul Elder <paul.elder@@ideasonboard.com>
> +
> +description:
> + The THP7312 is a standalone ISP controlled over i2c, and is capable of
> + various image processing and correction functions, including 3A control. It
> + can be connected to CMOS image sensors from various vendors, supporting both
> + MIPI CSI-2 and parallel interfaces. It can also output on either MIPI CSI-2
> + or parallel. The hardware is capable of transmitting and receiving MIPI
> + interlaved data strams with data types or multiple virtual channel
> + identifiers.
> +
> +allOf:
> + - $ref: ../video-interface-devices.yaml#
/schemas/media/...
> +
> +properties:
> + compatible:
> + const: thine,thp7312
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> + description: CLKI clock input
> +
> + thine,boot-mode:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 0
> + maximum: 1
> + default: 1
> + description:
> + Boot mode of the THP7312, reflecting the value of the BOOT[0] pin strap.
> + 0 is for the SPI/2-wire slave boot, 1 is for the SPI master boot (from
> + external flash ROM).
> +
> + reset-gpios:
> + maxItems: 1
> + description:
> + Reference to the GPIO connected to the RESET_N pin, if any.
> + Must be released (set high) after all supplies are applied.
> +
> + vddcore-supply:
> + description:
> + 1.2V supply for core, PLL, MIPI rx and MIPI tx.
> +
> + vhtermrx-supply:
> + description:
> + Supply for input (RX). 1.8V for MIPI, or 1.8/2.8/3.3V for parallel.
> +
> + vddtx-supply:
> + description:
> + Supply for output (TX). 1.8V for MIPI, or 1.8/2.8/3.3V for parallel.
> +
> + vddhost-supply:
> + description:
> + Supply for host interface. 1.8V, 2.8V, or 3.3V.
> +
> + vddcmos-supply:
> + description:
> + Supply for sensor interface. 1.8V, 2.8V, or 3.3V.
> +
> + vddgpio-0-supply:
> + description:
> + Supply for GPIO_0. 1.8V, 2.8V, or 3.3V.
> +
> + vddgpio-1-supply:
> + description:
> + Supply for GPIO_1. 1.8V, 2.8V, or 3.3V.
> +
> + orientation: true
> + rotation: true
> +
> + port:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + additionalProperties: false
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + bus-type:
> + const: 4 # CSI-2 D-PHY
> +
> + data-lanes:
> + description:
> + This property is for lane reordering between the THP7312 and the
> + SoC. The sensor supports either two-lane, or four-lane operation.
> + If this property is omitted four-lane operation is assumed. For
> + two-lane operation the property must be set to <1 2>.
> + minItems: 2
> + maxItems: 4
> + items:
> + maximum: 4
> +
> + sensors:
> + type: object
> + description: List of connected sensors
> +
> + properties:
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + patternProperties:
> + "^sensor@[01]":
Missing a '$' on the end.
> + type: object
> + description:
> + Sensors connected to the first and second input, with one node per
> + sensor.
> +
> + properties:
> + thine,model:
> + $ref: /schemas/types.yaml#/definitions/string
> + description:
> + Model of the connected sensors. Must be a valid compatible string.
> +
> + reg:
> + maxItems: 1
> + description: THP7312 input port number
items:
- maximum: 1
> +
> + data-lanes:
> + $ref: /schemas/media/video-interfaces.yaml#/properties/data-lanes
> + items:
> + maxItems: 4
> + description:
> + This property is for lane reordering between the THP7312 and the imaging
> + sensor that it is connected to.
> +
> + patternProperties:
> + ".*-supply":
"-supply$"
> + description: Power supplies for the sensor
Perhaps some reasoning why any supply name is allowed here?
> +
> + required:
> + - reg
> + - data-lanes
> +
> + additionalProperties: false
> +
> + required:
> + - "#address-cells"
> + - "#size-cells"
> +
> + additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - reset-gpios
> + - clocks
> + - vddcore-supply
> + - vhtermrx-supply
> + - vddtx-supply
> + - vddhost-supply
> + - vddcmos-supply
> + - vddgpio-0-supply
> + - vddgpio-1-supply
> + - sensors
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/media/video-interfaces.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + camera@61 {
> + compatible = "thine,thp7312";
> + reg = <0x61>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&cam1_pins_default>;
> +
> + reset-gpios = <&pio 119 GPIO_ACTIVE_LOW>;
> + clocks = <&camera61_clk>;
> +
> + vddcore-supply = <&vsys_v4p2>;
> + vhtermrx-supply = <&vsys_v4p2>;
> + vddtx-supply = <&vsys_v4p2>;
> + vddhost-supply = <&vsys_v4p2>;
> + vddcmos-supply = <&vsys_v4p2>;
> + vddgpio-0-supply = <&vsys_v4p2>;
> + vddgpio-1-supply = <&vsys_v4p2>;
> +
> + orientation = <0>;
> + rotation = <0>;
> +
> + sensors {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sensor@0 {
> + thine,model = "sony,imx258";
> + reg = <0>;
> +
> + data-lanes = <4 1 3 2>;
> +
> + dovdd-supply = <&vsys_v4p2>;
> + avdd-supply = <&vsys_v4p2>;
> + dvdd-supply = <&vsys_v4p2>;
> + };
> + };
> +
> + port {
> + thp7312_2_endpoint: endpoint {
> + remote-endpoint = <&mipi_thp7312_2>;
> + bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
> + data-lanes = <4 2 1 3>;
> + };
> + };
> + };
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f3e6dbbbbccb..2e094a7e7d07 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -21448,6 +21448,13 @@ S: Maintained
> F: Documentation/ABI/testing/sysfs-class-firmware-attributes
> F: drivers/platform/x86/think-lmi.?
>
> +THP7312 ISP DRIVER
> +M: Paul Elder <paul.elder@ideasonboard.com>
> +L: linux-media@vger.kernel.org
> +S: Maintained
> +T: git git://linuxtv.org/media_tree.git
> +F: Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml
> +
> THUNDERBOLT DMA TRAFFIC TEST DRIVER
> M: Isaac Hazan <isaac.hazan@intel.com>
> L: linux-usb@vger.kernel.org
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v5 1/3] dt-bindings: media: Add bindings for THine THP7312 ISP
2023-10-31 17:05 ` Rob Herring
@ 2023-11-02 0:47 ` Laurent Pinchart
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2023-11-02 0:47 UTC (permalink / raw)
To: Rob Herring
Cc: linux-media, Paul Elder, Hans Verkuil, Matthias Brugger,
AngeloGioacchino Del Regno, Julien Stephan, Sakari Ailus,
linux-mediatek, Krzysztof Kozlowski, Conor Dooley, devicetree
Hi Rob,
On Tue, Oct 31, 2023 at 12:05:25PM -0500, Rob Herring wrote:
> On Mon, Oct 30, 2023 at 03:32:45PM +0200, Laurent Pinchart wrote:
> > From: Paul Elder <paul.elder@ideasonboard.com>
> >
> > The THP7312 is an external ISP from THine. Add DT bindings for it.
> >
> > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> > Co-developed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > Changes since v4:
> >
> > - Add bus-type property
> >
> > Changes since v2:
> >
> > - Drop description of reg property
> > - Improve thine,boot-mode property documentation
> > - Making thine,boot-mode property optional
> > - Don't use underscores in supplies names
> > ---
> > .../bindings/media/i2c/thine,thp7312.yaml | 231 ++++++++++++++++++
> > MAINTAINERS | 7 +
> > 2 files changed, 238 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml b/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml
> > new file mode 100644
> > index 000000000000..a576a8669644
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml
> > @@ -0,0 +1,231 @@
[snip]
> > + sensors:
> > + type: object
> > + description: List of connected sensors
> > +
> > + properties:
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 0
> > +
> > + patternProperties:
> > + "^sensor@[01]":
>
> Missing a '$' on the end.
>
> > + type: object
> > + description:
> > + Sensors connected to the first and second input, with one node per
> > + sensor.
> > +
> > + properties:
> > + thine,model:
> > + $ref: /schemas/types.yaml#/definitions/string
> > + description:
> > + Model of the connected sensors. Must be a valid compatible string.
> > +
> > + reg:
> > + maxItems: 1
> > + description: THP7312 input port number
>
> items:
> - maximum: 1
>
> > +
> > + data-lanes:
> > + $ref: /schemas/media/video-interfaces.yaml#/properties/data-lanes
> > + items:
> > + maxItems: 4
> > + description:
> > + This property is for lane reordering between the THP7312 and the imaging
> > + sensor that it is connected to.
> > +
> > + patternProperties:
> > + ".*-supply":
>
> "-supply$"
>
> > + description: Power supplies for the sensor
>
> Perhaps some reasoning why any supply name is allowed here?
I've asked for more information about power supply sequencing, I have
hopes I will be able to simplify all this. If I can't I'll expand the
description. The idea is that the power supply names are specific to
each sensor. I can try to specify them with conditional rules if that's
preferred.
> > +
> > + required:
> > + - reg
> > + - data-lanes
> > +
> > + additionalProperties: false
> > +
> > + required:
> > + - "#address-cells"
> > + - "#size-cells"
> > +
> > + additionalProperties: false
[snip]
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-02 0:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-30 13:32 [PATCH v5 0/3] media: i2c: Add driver for THine THP7312 ISP Laurent Pinchart
2023-10-30 13:32 ` [PATCH v5 1/3] dt-bindings: media: Add bindings " Laurent Pinchart
2023-10-31 17:05 ` Rob Herring
2023-11-02 0:47 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).