From: Conor Dooley <conor@kernel.org>
To: Naveen Kumar <mnkumar@google.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
royluo@google.com, devicetree@vger.kernel.org
Subject: Re: [PATCH RESEND 2/2] dt-bindings: usb: add no-64-bit-support property
Date: Wed, 1 Nov 2023 10:38:00 +0000 [thread overview]
Message-ID: <20231101-diffused-iguana-f411619dc72a@spud> (raw)
In-Reply-To: <20231101101625.4151442-3-mnkumar@google.com>
[-- Attachment #1: Type: text/plain, Size: 1426 bytes --]
On Wed, Nov 01, 2023 at 10:16:25AM +0000, Naveen Kumar wrote:
> From: Naveen Kumar M <mnkumar@google.com>
>
> Add a new DT option to specify whether a host controller is able to
> support 64-bit DMA memory pointers
What host controllers are broken?
> Signed-off-by: Naveen Kumar M <mnkumar@google.com>
> ---
> Documentation/devicetree/bindings/usb/usb-xhci.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.yaml b/Documentation/devicetree/bindings/usb/usb-xhci.yaml
> index 180a261c3e8f..20dc134004f3 100644
> --- a/Documentation/devicetree/bindings/usb/usb-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.yaml
> @@ -25,6 +25,10 @@ properties:
> description: Set if the controller has broken port disable mechanism
> type: boolean
>
> + quirk-no-64-bit-support:
> + description: Set if the xHC doesn't support 64-bit DMA memory pointers
To set this property, you need to know that the host controller is
broken, so why not just make the driver set the quirk once it sees that
the host controller is one of the broken ones?
Unless there are "sometimes broken" host controllers, a dedicated
property should not be needed, right?
> + type: boolean
> +
> imod-interval-ns:
> description: Interrupt moderation interval
> default: 5000
> --
> 2.42.0.820.g83a721a137-goog
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-11-01 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 10:16 [PATCH RESEND 0/2] Add a quirk in xhci-plat for parent nodes to specify no 64 bit support Naveen Kumar
2023-11-01 10:16 ` [PATCH RESEND 1/2] usb: host: xhci-plat: Add quirk-no-64-bit-support Naveen Kumar
2023-11-01 10:16 ` [PATCH RESEND 2/2] dt-bindings: usb: add no-64-bit-support property Naveen Kumar
2023-11-01 10:38 ` Conor Dooley [this message]
2023-11-01 11:26 ` Krzysztof Kozlowski
2023-11-06 14:44 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231101-diffused-iguana-f411619dc72a@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mnkumar@google.com \
--cc=robh+dt@kernel.org \
--cc=royluo@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox