* [PATCH] dt-bindings: ufs: qcom: Add msi-parent for UFS MCQ
@ 2023-11-01 4:01 Ziqi Chen
2023-11-01 5:01 ` Manivannan Sadhasivam
0 siblings, 1 reply; 3+ messages in thread
From: Ziqi Chen @ 2023-11-01 4:01 UTC (permalink / raw)
To: quic_asutoshd, quic_cang, bvanassche, mani, beanhuo, avri.altman,
junwoo80.lee, martin.petersen, quic_ziqichen, quic_nguyenb,
quic_nitirawa, quic_rampraka
Cc: linux-scsi, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Alim Akhtar, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
open list:ARM/QUALCOMM SUPPORT,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
The Message Signaled Interrupt (MSI) has been used
by UFS driver since the MCQ be enabled. Hence in UFS
DT node, we need to give the msi-parent property that
point to the hardware entity that serves as the MSI
controller for this UFS controller.
Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com>
---
Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
index 462ead5..d2f505a 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
@@ -103,6 +103,8 @@ properties:
description:
GPIO connected to the RESET pin of the UFS memory device.
+ msi-parent: true
+
required:
- compatible
- reg
@@ -318,5 +320,6 @@ examples:
<0 0>,
<0 0>;
qcom,ice = <&ice>;
+ msi-parent = <&gic_its 0x60>;
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: ufs: qcom: Add msi-parent for UFS MCQ
2023-11-01 4:01 [PATCH] dt-bindings: ufs: qcom: Add msi-parent for UFS MCQ Ziqi Chen
@ 2023-11-01 5:01 ` Manivannan Sadhasivam
2023-11-01 7:48 ` Ziqi Chen
0 siblings, 1 reply; 3+ messages in thread
From: Manivannan Sadhasivam @ 2023-11-01 5:01 UTC (permalink / raw)
To: Ziqi Chen
Cc: quic_asutoshd, quic_cang, bvanassche, beanhuo, avri.altman,
junwoo80.lee, martin.petersen, quic_nguyenb, quic_nitirawa,
quic_rampraka, linux-scsi, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Alim Akhtar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, open list:ARM/QUALCOMM SUPPORT,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Wed, Nov 01, 2023 at 12:01:09PM +0800, Ziqi Chen wrote:
> The Message Signaled Interrupt (MSI) has been used
> by UFS driver since the MCQ be enabled. Hence in UFS
> DT node, we need to give the msi-parent property that
> point to the hardware entity that serves as the MSI
> controller for this UFS controller.
>
> Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com>
> ---
> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> index 462ead5..d2f505a 100644
> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> @@ -103,6 +103,8 @@ properties:
> description:
> GPIO connected to the RESET pin of the UFS memory device.
>
> + msi-parent: true
> +
This property is not Qcom specific. So this should be part of ufs-common.yaml.
- Mani
> required:
> - compatible
> - reg
> @@ -318,5 +320,6 @@ examples:
> <0 0>,
> <0 0>;
> qcom,ice = <&ice>;
> + msi-parent = <&gic_its 0x60>;
> };
> };
> --
> 2.7.4
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: ufs: qcom: Add msi-parent for UFS MCQ
2023-11-01 5:01 ` Manivannan Sadhasivam
@ 2023-11-01 7:48 ` Ziqi Chen
0 siblings, 0 replies; 3+ messages in thread
From: Ziqi Chen @ 2023-11-01 7:48 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: quic_asutoshd, quic_cang, bvanassche, beanhuo, avri.altman,
junwoo80.lee, martin.petersen, quic_nguyenb, quic_nitirawa,
quic_rampraka, linux-scsi, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Alim Akhtar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, open list:ARM/QUALCOMM SUPPORT,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 11/1/2023 1:01 PM, Manivannan Sadhasivam wrote:
> On Wed, Nov 01, 2023 at 12:01:09PM +0800, Ziqi Chen wrote:
>> The Message Signaled Interrupt (MSI) has been used
>> by UFS driver since the MCQ be enabled. Hence in UFS
>> DT node, we need to give the msi-parent property that
>> point to the hardware entity that serves as the MSI
>> controller for this UFS controller.
>>
>> Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com>
>> ---
>> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> index 462ead5..d2f505a 100644
>> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> @@ -103,6 +103,8 @@ properties:
>> description:
>> GPIO connected to the RESET pin of the UFS memory device.
>>
>> + msi-parent: true
>> +
>
> This property is not Qcom specific. So this should be part of ufs-common.yaml.
Make sense, thanks for review, I will update to ufs-common.yam.
>
> - Mani
>
>> required:
>> - compatible
>> - reg
>> @@ -318,5 +320,6 @@ examples:
>> <0 0>,
>> <0 0>;
>> qcom,ice = <&ice>;
>> + msi-parent = <&gic_its 0x60>;
>> };
>> };
>> --
>> 2.7.4
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-01 7:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-01 4:01 [PATCH] dt-bindings: ufs: qcom: Add msi-parent for UFS MCQ Ziqi Chen
2023-11-01 5:01 ` Manivannan Sadhasivam
2023-11-01 7:48 ` Ziqi Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox