Re: [PATCH 2/3] media: dt-bindings: ak7375: Add ak7345 support

Conor Dooley
2023-11-01T15:11:03Z

[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]

On Wed, Nov 01, 2023 at 11:22:56AM +0100, Vincent Knecht wrote:
> Document AK7345 bindings.

The commit message should mention why this device is incompatible with
the 7375. Something like

"Document the ak7345 voice coil motor actuator. Similar to the ak7375,
this model has 4 unilateral phase detractors instead of 8."

Otherwise,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

>
> Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
> ---
> .../devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml
> index 22a810fc7222..fe312cc6a873 100644
> --- a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml
> @@ -15,7 +15,9 @@ description:
>
> properties:
> compatible:
> - const: asahi-kasei,ak7375
> + enum:
> + - asahi-kasei,ak7345
> + - asahi-kasei,ak7375
>
> reg:
> maxItems: 1
> --
> 2.41.0
>
>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]