From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: alisadariana@gmail.com,
Alisa-Dariana Roman <alisa.roman@analog.com>,
Alexandru Tachici <alexandru.tachici@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Maksim Kiselev <bigunclemax@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Cosmin Tanislav <demonsingur@gmail.com>,
Okan Sahin <okan.sahin@analog.com>,
Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
Marius Cristea <marius.cristea@microchip.com>,
ChiaEn Wu <chiaen_wu@richtek.com>,
Marcus Folkesson <marcus.folkesson@gmail.com>,
Niklas Schnelle <schnelle@linux.ibm.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] iio: adc: ad7192: Add AD7194 support
Date: Mon, 6 Nov 2023 11:07:01 +0000 [thread overview]
Message-ID: <20231106110701.0c2a9a25@jic23-huawei> (raw)
In-Reply-To: <ZUi_kWzZBMRBs3EU@smile.fi.intel.com>
On Mon, 6 Nov 2023 12:27:29 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Sun, Nov 05, 2023 at 09:31:31PM +0200, alisadariana@gmail.com wrote:
> > From: Alisa-Dariana Roman <alisa.roman@analog.com>
> >
> > Unlike the other AD719Xs, AD7194 has configurable differential
> > channels. The default configuration for these channels can be changed
> > from the devicetree.
> >
> > The default configuration is hardcoded in order to have a stable number
> > of channels.
>
> ...
>
> > config AD7192
> > - tristate "Analog Devices AD7190 AD7192 AD7193 AD7195 ADC driver"
> > + tristate "Analog Devices AD7190 AD7192 AD7193 AD7194 AD7195 ADC driver"
>
> This doesn't scale. Please change this and below like:
>
> tristate "Analog Devices AD719x ADC driver"
Also tends to cause trouble given habit of manufacturers to not have consistent
naming.
"AD7194 and similar ADC driver"
would be my preference.
prev parent reply other threads:[~2023-11-06 11:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-05 19:31 [PATCH 0/3] iio: adc: ad7192: Add support for AD7194 alisadariana
2023-11-05 19:31 ` [PATCH 1/3] iio: adc: ad7192: Use device api alisadariana
2023-11-06 9:24 ` Krzysztof Kozlowski
2023-11-14 15:43 ` Alisa-Dariana Roman
2023-11-06 10:22 ` Andy Shevchenko
2023-11-05 19:31 ` [PATCH 2/3] dt-bindings: iio: adc: ad7192: Add AD7194 support alisadariana
2023-11-06 8:56 ` Krzysztof Kozlowski
2023-11-14 16:02 ` Alisa-Dariana Roman
2023-11-14 17:39 ` Krzysztof Kozlowski
2023-11-14 18:27 ` Alisa-Dariana Roman
2023-11-14 20:32 ` Krzysztof Kozlowski
2023-11-05 19:31 ` [PATCH 3/3] " alisadariana
2023-11-06 10:27 ` Andy Shevchenko
2023-11-06 11:07 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106110701.0c2a9a25@jic23-huawei \
--to=jic23@kernel.org \
--cc=Ibrahim.Tilki@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.tachici@analog.com \
--cc=alisa.roman@analog.com \
--cc=alisadariana@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bigunclemax@gmail.com \
--cc=chiaen_wu@richtek.com \
--cc=conor+dt@kernel.org \
--cc=demonsingur@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=marius.cristea@microchip.com \
--cc=okan.sahin@analog.com \
--cc=robh+dt@kernel.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).