From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B70CB30656; Wed, 8 Nov 2023 15:52:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L8TQ6UhZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64294C433C7; Wed, 8 Nov 2023 15:52:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699458737; bh=PyJnUw52xaJdt+qorcyNyHLF7M540bcPNwMFJlwFyck=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L8TQ6UhZsA/bjyxC4AJbD6rPwTX6WVEchB2F775eU8/kTYNTDGJ+WSg6ZPbwIjMGz aJOc3osG0JITpvpDm9jUybHOvPkXQmIOJoe7FyWLbBcGG5iDcIqjBS9IXYHE4DeNdc zVI/VpBTa8KQj9O6AGibuLqnCIvgtXAU3+wz8Z43sNQUpUZ9hnL51ENJjCuXlrk37q 6vAwwgBrMIO0TcU+foI8dQF3+O1CMzklQ7ujYIN6iJVeDykyUgScDkINBQiWY0bOUw wGrIkWA6mwne15L4T12Lwm8+aVLahU7gndkH9zsu8P6H/gN8Ay+NADlS/Iv/MFb4a4 U53hiMSHmCmNw== Date: Wed, 8 Nov 2023 15:52:11 +0000 From: Conor Dooley To: Dmitry Baryshkov Cc: Krishna chaitanya chundru , Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_vbadigan@quicinc.com, quic_ramkri@quicinc.com, quic_nitegupt@quicinc.com, quic_skananth@quicinc.com, quic_vpernami@quicinc.com, quic_parass@quicinc.com Subject: Re: [PATCH v2 1/3] dt-bindings: phy: qcom,qmp: Add PCIe qcom,refclk-always-on property Message-ID: <20231108-surgical-yelling-7314b68c0289@spud> References: <20231107-refclk_always_on-v2-0-de23962fc4b3@quicinc.com> <20231107-refclk_always_on-v2-1-de23962fc4b3@quicinc.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="I6wTmWiXLXK+QyIQ" Content-Disposition: inline In-Reply-To: --I6wTmWiXLXK+QyIQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 07, 2023 at 03:01:47PM +0200, Dmitry Baryshkov wrote: > On Tue, 7 Nov 2023 at 14:26, Krishna chaitanya chundru > wrote: > > > > Document qcom,refclk-always-on property which is needed in some platfor= ms > > to supply refclk even in PCIe low power states. > > > > Signed-off-by: Krishna chaitanya chundru > > --- > > .../devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml | 7= +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pc= ie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-= phy.yaml > > index 2c3d6553a7ba..263291447a5b 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.= yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.= yaml > > @@ -93,6 +93,13 @@ properties: > > "#phy-cells": > > const: 0 > > > > + qcom,refclk-always-on: > > + type: boolean > > + description: If there is some issues in platform with clkreq signal >=20 > nit: there are some >=20 > However this still doesn't describe what kind of issues with clkreq > you observe. I mean, clkreq is just a GPIO pin. >=20 > > + propagation to the host and due to that host will not send refcl= k, which > > + results in linkdown in L1.2 or L1.1 exit initiated by EP. This p= roperty > > + if set keeps refclk always on even in Low power states (optional= ). Dimitry's issues with the property aside, putting "(optional)" in the description is meaningless - qcom,refclk-always-on isn't listed in the required properties section, so therefore has to be optional. Cheers, Conor. > > + > > required: > > - compatible > > - reg > > > > -- > > 2.42.0 > > > > >=20 >=20 > --=20 > With best wishes > Dmitry --I6wTmWiXLXK+QyIQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZUuuqgAKCRB4tDGHoIJi 0ovuAP9SjB4TsXVP8krtEq82yxlmdE8R8V9/Q2naFBd1Ga9iywD/fwj/ihvpTrtK dvKdXSys+LPMPUK6nrpMhwYZkqMJTg0= =kRX+ -----END PGP SIGNATURE----- --I6wTmWiXLXK+QyIQ--