From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEB66650 for ; Wed, 8 Nov 2023 16:40:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 698891BFA; Wed, 8 Nov 2023 08:40:15 -0800 (PST) Received: by mail-oi1-f171.google.com with SMTP id 5614622812f47-3b5aee410f2so1605585b6e.1; Wed, 08 Nov 2023 08:40:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699461614; x=1700066414; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ssuYxHfN9GAnFK7fIA31znw/q0iB6aLpzguCXmB/ycM=; b=UO742Jwt9di7z6jW99hOFKYH7KvCdVo/Js6ecvILRRY8gBTI+FYorMeu37YXZKRqmT IPt+4EDOSly1H1yWz1Rvm0W6T8aMtU/qb0c9mpXsQy85d6fp/rRZXReHYCk2celRqLHN nZlvhqGcS6S6/TYR1R7mhIkJMs9mMQVnAUSN0yFQuevNZirVTLfg648JKcqbSWMeP4am 9LAQl+2D7hVbKEGzzmYd9BsKCLtPKBiZ9ejimivFuvgMtoZEHeLFHczwJqsIbn1RoozD qV78cJrywDIuDxa35D7x6F4L8zLe9vRzTrzMTGwMRaM4OimAKXVs6qFCi+/Vr4Dbov5E j1hQ== X-Gm-Message-State: AOJu0YwbGC40gP4Rb2ZyqMpzYuvTnvHBnmrILY284PPaUWp/W6AWoAa/ wSD11hoDrmeZjo8HNdhwpg== X-Google-Smtp-Source: AGHT+IGXYQ4NWuhknPwkgNGSEQUWD6c5qRqqAmhMQTB6tTEvVpofwZw28IPC+YMCrYLivbXk6k+J5g== X-Received: by 2002:aca:905:0:b0:3af:26e3:92e with SMTP id 5-20020aca0905000000b003af26e3092emr2345076oij.28.1699461614688; Wed, 08 Nov 2023 08:40:14 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id bk31-20020a0568081a1f00b003a7a34a4ed8sm1940758oib.33.2023.11.08.08.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 08:40:14 -0800 (PST) Received: (nullmailer pid 2362820 invoked by uid 1000); Wed, 08 Nov 2023 16:40:12 -0000 Date: Wed, 8 Nov 2023 10:40:12 -0600 From: Rob Herring To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Krzysztof Kozlowski , Wim Van Sebroeck , Guenter Roeck , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hector Martin , Sven Peter , Alyssa Rosenzweig , Julius Werner , Evan Benn , Florian Fainelli , Broadcom internal kernel review list , Maxime Ripard , Oleksij Rempel , Justin Chen , Baruch Siach , Ahmad Zainie , Marc Zyngier , Linus Walleij , Jamie Iles , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, asahi@lists.linux.dev Subject: Re: [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention Message-ID: <20231108164012.GA2336524-robh@kernel.org> References: <20231105184154.43700-1-krzysztof.kozlowski@linaro.org> <300293570c0d29d5d4a39762121b5bef@milecki.pl> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <300293570c0d29d5d4a39762121b5bef@milecki.pl> On Mon, Nov 06, 2023 at 09:10:44AM +0100, Rafał Miłecki wrote: > On 2023-11-05 19:41, Krzysztof Kozlowski wrote: > > The Devicetree bindings coding convention, as used in most of the files > > and expressed in Documentation/devicetree/bindings/example-schema.yaml, > > expects: > > 1. "allOf:" block just before "properties:" (or after "required:" for > > more complex cases), > > 2. additionalProperties/unevaluatedProperties at the end of the file, > > just before the examples section. > > > > Re-order few schemas to match the convention to avoid repeating review > > comments for new patches using existing code as template. No functional > > changes. > > It's surely going to help a bit but for a long time solution maybe you > could consider adding proper check to Rob's bot and/or checkpatch.pl. I have such a check I wrote long ago. tools/yaml-format in dtschema. It just does a ruamel read and write back out so you get exactly how ruamel is configured or defaults to for things not configurable. Primarily, the non-configurable part is multi-line text without a '|'. So lots of 'description' paragraphs are reformatted. It ends up being too strict IMO. The key order is checked, but not fixed. Probably could add reordering. Adding this by default (and to the bot) means fixing *every* file in tree first. That's not something I care to do and enforce. Rob