[PATCH 0/1] Switch on USB as a wakeup source on sm8250

[PATCH 0/1] Switch on USB as a wakeup source on sm8250

[Bryan O'Donoghue]

Add in wakeup-source to both USB controllers on sm8250.

I tested that the rb5 gets into and stays in s2idle, subsequently resuming
when a key is pressed on an attached USB keyboard for both Type-A USB 3
ports and via the TCPM controlled Type-C port.

Bryan O'Donoghue (1):
  arm64: dts: qcom: sm8250: Add wakeup-source to usb_1 and usb_2

 arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.42.0

[PATCH 1/1] arm64: dts: qcom: sm8250: Add wakeup-source to usb_1 and usb_2

[Bryan O'Donoghue]

To test out a different GDSC change I wanted to have a USB keypress resume
a system in suspend.

Adding wakeup-source to usb_1 and usb_2 "just works" for me on rb5.
Consistent with qcm2290 and sa8775p add wakeup-source to the dtsi for the
SoC.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index e43a16df4c7ec..c2d929e62c840 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -3878,6 +3878,7 @@ usb_1: usb@a6f8800 {
 					  "dp_hs_phy_irq";
 
 			power-domains = <&gcc USB30_PRIM_GDSC>;
+			wakeup-source;
 
 			resets = <&gcc GCC_USB30_PRIM_BCR>;
 
@@ -3942,6 +3943,7 @@ usb_2: usb@a8f8800 {
 					  "dp_hs_phy_irq";
 
 			power-domains = <&gcc USB30_SEC_GDSC>;
+			wakeup-source;
 
 			resets = <&gcc GCC_USB30_SEC_BCR>;
 
-- 
2.42.0

Re: [PATCH 1/1] arm64: dts: qcom: sm8250: Add wakeup-source to usb_1 and usb_2

[Konrad Dybcio]

On 11/9/23 01:43, Bryan O'Donoghue wrote:
> To test out a different GDSC change I wanted to have a USB keypress resume
> a system in suspend.
> 
> Adding wakeup-source to usb_1 and usb_2 "just works" for me on rb5.
> Consistent with qcm2290 and sa8775p add wakeup-source to the dtsi for the
> SoC.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Maybe we could make it the default in qcom glue somehow..

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Re: (subset) [PATCH 0/1] Switch on USB as a wakeup source on sm8250

[Bjorn Andersson]

On Thu, 09 Nov 2023 00:43:10 +0000, Bryan O'Donoghue wrote:
> Add in wakeup-source to both USB controllers on sm8250.
> 
> I tested that the rb5 gets into and stays in s2idle, subsequently resuming
> when a key is pressed on an attached USB keyboard for both Type-A USB 3
> ports and via the TCPM controlled Type-C port.
> 
> Bryan O'Donoghue (1):
>   arm64: dts: qcom: sm8250: Add wakeup-source to usb_1 and usb_2
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: sm8250: Add wakeup-source to usb_1 and usb_2
      commit: 48307d83c998db18db6890dccb569146eb12d313

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>