From: Chris Morgan <macroalpha82@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
sebastian.reichel@collabora.com, daniel@ffwll.ch,
airlied@gmail.com, sam@ravnborg.org, neil.armstrong@linaro.org,
heiko@sntech.de, conor+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
Chris Morgan <macromorgan@hotmail.com>
Subject: [PATCH V2 1/4] dt-bindings: display: panel: Update NewVision NV3051D compatibles
Date: Thu, 9 Nov 2023 15:50:04 -0600 [thread overview]
Message-ID: <20231109215007.66826-2-macroalpha82@gmail.com> (raw)
In-Reply-To: <20231109215007.66826-1-macroalpha82@gmail.com>
From: Chris Morgan <macromorgan@hotmail.com>
Update the NewVision NV3051D compatible strings by adding a new panel,
the powkiddy,rk2023-panel, and removing another entry, the
anbernic,rg353v-panel. The rg353v-panel is exactly identical to the
rg353p-panel and is not currently in use by any existing device tree.
The rk2023-panel is similar to the rg353p-panel but has slightly
different timings.
I originally wrote the driver checking for the newvision,nv3051d
compatible string which worked fine when there was only 1 panel type.
When I added support for the 351v-panel I *should* have changed how the
compatible string was handled, but instead I simply added a check in the
probe function to look for the secondary string of
"anbernic,rg351v-panel". Now that I am adding the 3rd panel type of
"powkiddy,rk2023-panel" I am correcting the driver to do it the right
way by checking for the specific compatibles.
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
.../devicetree/bindings/display/panel/newvision,nv3051d.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml
index cce775a87f87..7a634fbc465e 100644
--- a/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml
+++ b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml
@@ -21,7 +21,7 @@ properties:
- enum:
- anbernic,rg351v-panel
- anbernic,rg353p-panel
- - anbernic,rg353v-panel
+ - powkiddy,rk2023-panel
- const: newvision,nv3051d
reg: true
--
2.34.1
next prev parent reply other threads:[~2023-11-09 21:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 21:50 [PATCH V2 0/4] rockchip: Add Powkiddy RK2023 Chris Morgan
2023-11-09 21:50 ` Chris Morgan [this message]
2023-11-10 13:11 ` [PATCH V2 1/4] dt-bindings: display: panel: Update NewVision NV3051D compatibles Krzysztof Kozlowski
2023-11-10 14:28 ` Chris Morgan
2023-11-10 14:52 ` Krzysztof Kozlowski
2023-11-09 21:50 ` [PATCH V2 2/4] nv3051d: Add Powkiddy RK2023 Panel Support Chris Morgan
2023-11-15 22:37 ` Jessica Zhang
2023-11-09 21:50 ` [PATCH V2 3/4] dt-bindings: arm: rockchip: Add Powkiddy RK2023 Chris Morgan
2023-11-10 13:12 ` Krzysztof Kozlowski
2023-11-09 21:50 ` [PATCH V2 4/4] arm64: dts: rockchip: add " Chris Morgan
2023-11-10 13:14 ` Krzysztof Kozlowski
2023-11-10 14:30 ` Chris Morgan
2023-11-10 15:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231109215007.66826-2-macroalpha82@gmail.com \
--to=macroalpha82@gmail.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).