* [PATCH] dt-bindings: usb: qcom,dwc3: adjust number of interrupts on SM6125
@ 2023-11-11 14:19 Krzysztof Kozlowski
2023-11-11 16:24 ` Conor Dooley
2023-11-21 21:20 ` Marijn Suijten
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-11 14:19 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Greg Kroah-Hartman,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Wesley Cheng,
linux-arm-msm, linux-usb, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Qualcomm SM6125 DWC3 USB controller comes with two interrupts (verified
with downstream/vendor code of Trinket DTSI from Xiaomi Laurel device).
Move the qcom,sm6125-dwc3 to appropriate place in allOf:if:then blocks
constraining interrupts.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index 64043b91ffb9..3f41362b2a91 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -375,7 +375,6 @@ allOf:
- qcom,sdx65-dwc3
- qcom,sdx75-dwc3
- qcom,sm4250-dwc3
- - qcom,sm6125-dwc3
- qcom,sm6350-dwc3
- qcom,sm8150-dwc3
- qcom,sm8250-dwc3
@@ -408,6 +407,7 @@ allOf:
- qcom,msm8996-dwc3
- qcom,msm8998-dwc3
- qcom,sm6115-dwc3
+ - qcom,sm6125-dwc3
then:
properties:
interrupts:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: usb: qcom,dwc3: adjust number of interrupts on SM6125
2023-11-11 14:19 [PATCH] dt-bindings: usb: qcom,dwc3: adjust number of interrupts on SM6125 Krzysztof Kozlowski
@ 2023-11-11 16:24 ` Conor Dooley
2023-11-21 21:20 ` Marijn Suijten
1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2023-11-11 16:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Greg Kroah-Hartman,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Wesley Cheng,
linux-arm-msm, linux-usb, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]
On Sat, Nov 11, 2023 at 03:19:53PM +0100, Krzysztof Kozlowski wrote:
> Qualcomm SM6125 DWC3 USB controller comes with two interrupts (verified
> with downstream/vendor code of Trinket DTSI from Xiaomi Laurel device).
> Move the qcom,sm6125-dwc3 to appropriate place in allOf:if:then blocks
> constraining interrupts.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> ---
> Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> index 64043b91ffb9..3f41362b2a91 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> @@ -375,7 +375,6 @@ allOf:
> - qcom,sdx65-dwc3
> - qcom,sdx75-dwc3
> - qcom,sm4250-dwc3
> - - qcom,sm6125-dwc3
> - qcom,sm6350-dwc3
> - qcom,sm8150-dwc3
> - qcom,sm8250-dwc3
> @@ -408,6 +407,7 @@ allOf:
> - qcom,msm8996-dwc3
> - qcom,msm8998-dwc3
> - qcom,sm6115-dwc3
> + - qcom,sm6125-dwc3
> then:
> properties:
> interrupts:
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: usb: qcom,dwc3: adjust number of interrupts on SM6125
2023-11-11 14:19 [PATCH] dt-bindings: usb: qcom,dwc3: adjust number of interrupts on SM6125 Krzysztof Kozlowski
2023-11-11 16:24 ` Conor Dooley
@ 2023-11-21 21:20 ` Marijn Suijten
1 sibling, 0 replies; 3+ messages in thread
From: Marijn Suijten @ 2023-11-21 21:20 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Greg Kroah-Hartman,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Wesley Cheng,
linux-arm-msm, linux-usb, devicetree, linux-kernel
On 2023-11-11 15:19:53, Krzysztof Kozlowski wrote:
> Qualcomm SM6125 DWC3 USB controller comes with two interrupts (verified
> with downstream/vendor code of Trinket DTSI from Xiaomi Laurel device).
> Move the qcom,sm6125-dwc3 to appropriate place in allOf:if:then blocks
> constraining interrupts.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Agreed. I believe this is what I got stuck on when trying to address the
warning over a year ago [1]. It makes sense to drop the dm_hs_phy_irq and
dp_hs_phy_irq interrupts entirely.
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
[1]: https://github.com/somainline/linux/commit/b57f7fa80cb3f5cd2db3db2d79548cbf063056d9
> ---
> Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> index 64043b91ffb9..3f41362b2a91 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> @@ -375,7 +375,6 @@ allOf:
> - qcom,sdx65-dwc3
> - qcom,sdx75-dwc3
> - qcom,sm4250-dwc3
> - - qcom,sm6125-dwc3
> - qcom,sm6350-dwc3
> - qcom,sm8150-dwc3
> - qcom,sm8250-dwc3
> @@ -408,6 +407,7 @@ allOf:
> - qcom,msm8996-dwc3
> - qcom,msm8998-dwc3
> - qcom,sm6115-dwc3
> + - qcom,sm6125-dwc3
> then:
> properties:
> interrupts:
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-21 21:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-11 14:19 [PATCH] dt-bindings: usb: qcom,dwc3: adjust number of interrupts on SM6125 Krzysztof Kozlowski
2023-11-11 16:24 ` Conor Dooley
2023-11-21 21:20 ` Marijn Suijten
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).