From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD42A46524; Thu, 16 Nov 2023 18:34:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GxzYQgfX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C348C433C8; Thu, 16 Nov 2023 18:34:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700159660; bh=8EhJKo8rDeezKqxLzMDL7DCLOC6nqzPZCy8ff/Ayqe8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GxzYQgfX6q6Qrk30HeKvn5JTCTDM4xnC9E62Ky78pyXCsCpuwnhHWYNOLpqJeoS69 jXrNYndJ1RNR0GrPzvtu4KF+txcfx6nxgKaaM/yebJ+PrZ4wTvQUdpo9CkKFR6aq9f liU+UUd76DmQahOVwgWLldkF3hUEc352EUWtArptO1Z7R7rk/ai32G/x0K5ui3Jvw/ lB1kfJ3/YMyar+tzvnnBJGmr8j43nmyddwH5G+2pw6mriYvglmKOOwi1+igINbrv5O mOwuEcanj2bpiv0H8AEugX4oZ+ohKmJ/amHFUkQ28APHiNOW9NEfoGjC3kCYn6ynU8 W30nira3eBMzQ== Date: Thu, 16 Nov 2023 18:34:16 +0000 From: Conor Dooley To: Andreas Klinger Cc: Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lars-Peter Clausen , Petre Rodan , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: honeywell,mprls0025pa.yaml: fix function numbering Message-ID: <20231116-grudge-hankering-b7a71d831b93@squawk> References: <20231116182443.7290-1-ak@it-klinger.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hdaK5Truep84srtq" Content-Disposition: inline In-Reply-To: <20231116182443.7290-1-ak@it-klinger.de> --hdaK5Truep84srtq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 16, 2023 at 07:24:43PM +0100, Andreas Klinger wrote: > Fix wrongly documented numbering of transfer functions. >=20 > Fixes: a765c985e696 ("dt-bindings: iio: pressure: Support Honeywell mprls= 0025pa sensor") > No blank line here. > Suggested-by: Petre Rodan This should be Reported-by. > Signed-off-by: Andreas Klinger > --- > .../bindings/iio/pressure/honeywell,mprls0025pa.yaml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mpr= ls0025pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mp= rls0025pa.yaml > index b31f8120f14e..61775eff1128 100644 > --- a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025p= a.yaml > +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025p= a.yaml > @@ -64,9 +64,9 @@ properties: > description: | > Transfer function which defines the range of valid values delivere= d by the > sensor. > - 1 - A, 10% to 90% of 2^24 (1677722 .. 15099494) > - 2 - B, 2.5% to 22.5% of 2^24 (419430 .. 3774874) > - 3 - C, 20% to 80% of 2^24 (3355443 .. 13421773) > + 0 - A, 10% to 90% of 2^24 (1677722 .. 15099494) > + 1 - B, 2.5% to 22.5% of 2^24 (419430 .. 3774874) > + 2 - C, 20% to 80% of 2^24 (3355443 .. 13421773) I don't understand. These are arbitrary numbers in a dt-binding, why does zero or one indexing make any difference here? Can't you just fix up the driver to correctly map the dt-binding to whatever needs to be written to registers in the hardware? Cheers, Conor. > $ref: /schemas/types.yaml#/definitions/uint32 > =20 > vdd-supply: > --=20 > 2.39.2 >=20 --hdaK5Truep84srtq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZVZgpQAKCRB4tDGHoIJi 0ro9AP41/miHXh7XhWfNmwyktMkO3qn/gHtMyuEiySwMJSiQygEA5W0rZahN92ag PUp2JscwQiOwmt7fQzs1cJb7N8aOvgI= =C+WP -----END PGP SIGNATURE----- --hdaK5Truep84srtq--