* [PATCH] media: dt-bindings: media: rkisp1: Fix the port description for the parallel interface
@ 2023-11-15 16:44 Mehdi Djait
2023-11-16 0:51 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Mehdi Djait @ 2023-11-15 16:44 UTC (permalink / raw)
To: krzysztof.kozlowski+dt, robh+dt, conor+dt
Cc: linux-media, devicetree, linux-kernel, thomas.petazzoni,
alexandre.belloni, paul.kocialkowski, dafna, laurent.pinchart,
helen.koike, heiko, paul.elder, Mehdi Djait
The bus-type belongs to the endpoint's properties and should therefore
be moved.
Fixes: 6a0eaa25bf36 ("media: dt-bindings: media: rkisp1: Add port for parallel interface")
Signed-off-by: Mehdi Djait <mehdi.djait@bootlin.com>
---
.../devicetree/bindings/media/rockchip-isp1.yaml | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
index e466dff8286d..afcaa427d48b 100644
--- a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
+++ b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
@@ -90,15 +90,16 @@ properties:
description: connection point for input on the parallel interface
properties:
- bus-type:
- enum: [5, 6]
-
endpoint:
$ref: video-interfaces.yaml#
unevaluatedProperties: false
- required:
- - bus-type
+ properties:
+ bus-type:
+ enum: [5, 6]
+
+ required:
+ - bus-type
anyOf:
- required:
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] media: dt-bindings: media: rkisp1: Fix the port description for the parallel interface
2023-11-15 16:44 [PATCH] media: dt-bindings: media: rkisp1: Fix the port description for the parallel interface Mehdi Djait
@ 2023-11-16 0:51 ` Laurent Pinchart
2023-11-16 14:37 ` Conor Dooley
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2023-11-16 0:51 UTC (permalink / raw)
To: Mehdi Djait
Cc: krzysztof.kozlowski+dt, robh+dt, conor+dt, linux-media,
devicetree, linux-kernel, thomas.petazzoni, alexandre.belloni,
paul.kocialkowski, dafna, helen.koike, heiko, paul.elder
Hi Mehdi,
Thank you for the patch.
On Wed, Nov 15, 2023 at 05:44:07PM +0100, Mehdi Djait wrote:
> The bus-type belongs to the endpoint's properties and should therefore
> be moved.
>
> Fixes: 6a0eaa25bf36 ("media: dt-bindings: media: rkisp1: Add port for parallel interface")
> Signed-off-by: Mehdi Djait <mehdi.djait@bootlin.com>
Good catch.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../devicetree/bindings/media/rockchip-isp1.yaml | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
> index e466dff8286d..afcaa427d48b 100644
> --- a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
> @@ -90,15 +90,16 @@ properties:
> description: connection point for input on the parallel interface
>
> properties:
> - bus-type:
> - enum: [5, 6]
> -
> endpoint:
> $ref: video-interfaces.yaml#
> unevaluatedProperties: false
>
> - required:
> - - bus-type
> + properties:
> + bus-type:
> + enum: [5, 6]
> +
> + required:
> + - bus-type
>
> anyOf:
> - required:
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: dt-bindings: media: rkisp1: Fix the port description for the parallel interface
2023-11-16 0:51 ` Laurent Pinchart
@ 2023-11-16 14:37 ` Conor Dooley
0 siblings, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2023-11-16 14:37 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Mehdi Djait, krzysztof.kozlowski+dt, robh+dt, conor+dt,
linux-media, devicetree, linux-kernel, thomas.petazzoni,
alexandre.belloni, paul.kocialkowski, dafna, helen.koike, heiko,
paul.elder
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
On Thu, Nov 16, 2023 at 02:51:40AM +0200, Laurent Pinchart wrote:
> On Wed, Nov 15, 2023 at 05:44:07PM +0100, Mehdi Djait wrote:
> > The bus-type belongs to the endpoint's properties and should therefore
> > be moved.
> >
> > Fixes: 6a0eaa25bf36 ("media: dt-bindings: media: rkisp1: Add port for parallel interface")
> > Signed-off-by: Mehdi Djait <mehdi.djait@bootlin.com>
>
> Good catch.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-16 14:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-15 16:44 [PATCH] media: dt-bindings: media: rkisp1: Fix the port description for the parallel interface Mehdi Djait
2023-11-16 0:51 ` Laurent Pinchart
2023-11-16 14:37 ` Conor Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).