Re: [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller driver

Andrew Lunn
2023-11-22T17:11:38Z

> > Is the firmware in Motorola SREC format? I thought the kernel had a
> > helper for that, but a quick search did not find it. So maybe i'm
> > remembering wrongly. But it seems silly for every driver to implement
> > an SREC parser.
>
> Oh, I didn't know this format.

Its often used in small deeply embedded systems. Microcontrollers,
rather than something which can run Linux.

> The firmware seems indeed to match this format
> specification.
> I found two reference of this Firmware format in the kernel:
> https://elixir.bootlin.com/linux/v6.5.7/source/sound/soc/codecs/zl38060.c#L178
> https://elixir.bootlin.com/linux/v6.5.7/source/drivers/staging/wlan-ng/prism2fw.c

Ah, all inside a header file. Probably why i missed it. But ihex is
not SREC. ihex came from Intel. SREC from Motorola.

So i would follow the basic flow in include/linux/ihex.h, add an
include/linux/srec.h but adapt it for SREC.

Andrew