Re: [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller driver

Köry Maincent
2023-11-16T14:59:51Z

Thanks Krzysztof for your reviews!

On Thu, 16 Nov 2023 15:29:24 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 16/11/2023 15:01, Kory Maincent wrote:
> > Add a new driver for the PD692x0 I2C Power Sourcing Equipment controller.
> > This driver only support i2c communication for now.
> >
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > ---
> > MAINTAINERS | 1 +
> > drivers/net/pse-pd/Kconfig | 11 +
> > drivers/net/pse-pd/Makefile | 1 +
> > drivers/net/pse-pd/pd692x0.c | 1049
> > ++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 1062
> > insertions(+)
>
> ....
>
> > +
> > +err_fw_unregister:
> > + firmware_upload_unregister(priv->fwl);
> > + return ret;
> > +}
> > +
> > +static void pd692x0_i2c_remove(struct i2c_client *client)
> > +{
> > + struct pd692x0_priv *priv = i2c_get_clientdata(client);
> > +
> > + firmware_upload_unregister(priv->fwl);
> > +}
> > +
> > +static const struct i2c_device_id pd692x0_id[] = {
> > + { PD692X0_PSE_NAME, 0 },
> > + { },
> > +};
> > +MODULE_DEVICE_TABLE(i2c, pd692x0_id);
> > +
> > +static const struct of_device_id pd692x0_of_match[] = {
> > + { .compatible = "microchip,pd69200", },
> > + { .compatible = "microchip,pd69210", },
> > + { .compatible = "microchip,pd69220", },
>
> So they are the same from driver point of view.

Yes.
I only have the pd69200 version but the three versions are theoretically
compatible and microchip advise obviously to use the last one.
I describe the three names in case of future specific things even if I hope
there won't be and to have a clear version of which version is supported. Do you
prefer to use pd692x0 compatible instead?

Regards,

--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering