From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com [209.85.161.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79252189; Thu, 16 Nov 2023 08:22:52 -0800 (PST) Received: by mail-oo1-f51.google.com with SMTP id 006d021491bc7-5875c300becso558346eaf.0; Thu, 16 Nov 2023 08:22:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700151772; x=1700756572; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Bs8icm+iMMidy4R85L/9ZGbmCFlh9//SffKirAVv9pQ=; b=BkVVVDhVU0yOLcdoM8XbCtYBZE63WSqRBfyCc0fzYZqxT4bNJVcuQvgMxr0sZK+Cj0 6/l+tZkhrGQikjxsAm+0M6CCFxzpHnh7ePBjwS1bTCNg68i3JBMCGAS7Yq6V6N5hvw5L LU9+kdaVgEklRv4GCCN+up4Cu9/s7kkovz1Y15hqFSOkP5lMUVfu52OHi8tD25+x6Sws QS9jaldNDkN14VifA49R2VHwA55YwAjTcV/CVPbWpWBjQ5Pl1ypr5gPOD28lh34es1ij me4SGeAVkWni5GqX9ja1iIvxFA+S1wpmXA5g2axroEi5tmqML08t9ZHQjc/a5ROwBxlS aBVA== X-Gm-Message-State: AOJu0YwuC859e7j8xUBnQ7xJMasgbBgBGgnTIx/pYihUJ5huhnDWdbjt ToFh+FtOzvaKBTTqvDEhUg== X-Google-Smtp-Source: AGHT+IFnKbCB5st7hQU+OKvwZLFiA+nmISbSf/raMUvn3R7EMCMOsFN+4Xt1evr/F2ThXJZzS1wIIw== X-Received: by 2002:a4a:3443:0:b0:581:40d0:7166 with SMTP id n3-20020a4a3443000000b0058140d07166mr16693216oof.8.1700151767156; Thu, 16 Nov 2023 08:22:47 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id c1-20020a4aacc1000000b0058a1d87d96csm1088314oon.41.2023.11.16.08.22.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 08:22:46 -0800 (PST) Received: (nullmailer pid 2431114 invoked by uid 1000); Thu, 16 Nov 2023 16:22:45 -0000 Date: Thu, 16 Nov 2023 10:22:45 -0600 From: Rob Herring To: Viresh Kumar Cc: David Dai , "Rafael J. Wysocki" , Krzysztof Kozlowski , Conor Dooley , Sudeep Holla , Saravana Kannan , Quentin Perret , Masami Hiramatsu , Will Deacon , Peter Zijlstra , Vincent Guittot , Marc Zyngier , Oliver Upton , Dietmar Eggemann , Pavan Kondeti , Gupta Pankaj , Mel Gorman , kernel-team@android.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/2] dt-bindings: cpufreq: add virtual cpufreq device Message-ID: <20231116162245.GA2424810-robh@kernel.org> References: <20231111014933.1934562-1-davidai@google.com> <20231111014933.1934562-2-davidai@google.com> <20231115062741.v3tpm337c2lidxzr@vireshk-i7> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231115062741.v3tpm337c2lidxzr@vireshk-i7> On Wed, Nov 15, 2023 at 11:57:41AM +0530, Viresh Kumar wrote: > On 10-11-23, 17:49, David Dai wrote: > > diff --git a/Documentation/devicetree/bindings/cpufreq/qemu,cpufreq-virtual.yaml b/Documentation/devicetree/bindings/cpufreq/qemu,cpufreq-virtual.yaml > > +$id: http://devicetree.org/schemas/cpufreq/qemu,cpufreq-virtual.yaml# > > +properties: > > + compatible: > > + const: qemu,virtual-cpufreq > > Not sure why we need to mention QEMU here.. Why limit this to just QEMU ? Because that is the implementation. And also to discourage anyone from using this on their hardware or thinking it is generic and the way to extend it to another implementation is adding properties. Rob