* [PATCH] arm64: dts: qcom: qrb5165-rb5: correct LED panic indicator
@ 2023-11-11 9:46 Krzysztof Kozlowski
2023-11-13 12:04 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-11 9:46 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
There is no "panic-indicator" default trigger but a property with that
name:
qrb5165-rb5.dtb: leds: led-user4: Unevaluated properties are not allowed ('linux,default-trigger' was unexpected)
Fixes: b5cbd84e499a ("arm64: dts: qcom: qrb5165-rb5: Add onboard LED support")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
index 3bd0c06e7315..e43f73f1be1b 100644
--- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
+++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
@@ -64,8 +64,8 @@ led-user4 {
function = LED_FUNCTION_INDICATOR;
color = <LED_COLOR_ID_GREEN>;
gpios = <&pm8150_gpios 10 GPIO_ACTIVE_HIGH>;
- linux,default-trigger = "panic-indicator";
default-state = "off";
+ panic-indicator;
};
led-wlan {
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: qrb5165-rb5: correct LED panic indicator
2023-11-11 9:46 [PATCH] arm64: dts: qcom: qrb5165-rb5: correct LED panic indicator Krzysztof Kozlowski
@ 2023-11-13 12:04 ` Konrad Dybcio
2023-11-17 10:47 ` Manivannan Sadhasivam
2023-12-08 2:57 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2023-11-13 12:04 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
linux-arm-msm, devicetree, linux-kernel
On 11.11.2023 10:46, Krzysztof Kozlowski wrote:
> There is no "panic-indicator" default trigger but a property with that
> name:
>
> qrb5165-rb5.dtb: leds: led-user4: Unevaluated properties are not allowed ('linux,default-trigger' was unexpected)
>
> Fixes: b5cbd84e499a ("arm64: dts: qcom: qrb5165-rb5: Add onboard LED support")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: qrb5165-rb5: correct LED panic indicator
2023-11-11 9:46 [PATCH] arm64: dts: qcom: qrb5165-rb5: correct LED panic indicator Krzysztof Kozlowski
2023-11-13 12:04 ` Konrad Dybcio
@ 2023-11-17 10:47 ` Manivannan Sadhasivam
2023-12-08 2:57 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2023-11-17 10:47 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On Sat, Nov 11, 2023 at 10:46:23AM +0100, Krzysztof Kozlowski wrote:
> There is no "panic-indicator" default trigger but a property with that
> name:
>
> qrb5165-rb5.dtb: leds: led-user4: Unevaluated properties are not allowed ('linux,default-trigger' was unexpected)
>
> Fixes: b5cbd84e499a ("arm64: dts: qcom: qrb5165-rb5: Add onboard LED support")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> index 3bd0c06e7315..e43f73f1be1b 100644
> --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> @@ -64,8 +64,8 @@ led-user4 {
> function = LED_FUNCTION_INDICATOR;
> color = <LED_COLOR_ID_GREEN>;
> gpios = <&pm8150_gpios 10 GPIO_ACTIVE_HIGH>;
> - linux,default-trigger = "panic-indicator";
> default-state = "off";
> + panic-indicator;
> };
>
> led-wlan {
> --
> 2.34.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: qrb5165-rb5: correct LED panic indicator
2023-11-11 9:46 [PATCH] arm64: dts: qcom: qrb5165-rb5: correct LED panic indicator Krzysztof Kozlowski
2023-11-13 12:04 ` Konrad Dybcio
2023-11-17 10:47 ` Manivannan Sadhasivam
@ 2023-12-08 2:57 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2023-12-08 2:57 UTC (permalink / raw)
To: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Manivannan Sadhasivam, linux-arm-msm, devicetree,
linux-kernel, Krzysztof Kozlowski
On Sat, 11 Nov 2023 10:46:23 +0100, Krzysztof Kozlowski wrote:
> There is no "panic-indicator" default trigger but a property with that
> name:
>
> qrb5165-rb5.dtb: leds: led-user4: Unevaluated properties are not allowed ('linux,default-trigger' was unexpected)
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: qrb5165-rb5: correct LED panic indicator
commit: dc6b5562acbac0285ab3b2dad23930b6434bdfc6
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-08 2:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-11 9:46 [PATCH] arm64: dts: qcom: qrb5165-rb5: correct LED panic indicator Krzysztof Kozlowski
2023-11-13 12:04 ` Konrad Dybcio
2023-11-17 10:47 ` Manivannan Sadhasivam
2023-12-08 2:57 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).