From: Jakub Kicinski <kuba@kernel.org>
To: Luo Jie <quic_luoj@quicinc.com>
Cc: <andrew@lunn.ch>, <davem@davemloft.net>, <edumazet@google.com>,
<pabeni@redhat.com>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<hkallweit1@gmail.com>, <linux@armlinux.org.uk>, <corbet@lwn.net>,
<netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v5 3/6] net: phy: at803x: add QCA8084 ethernet phy support
Date: Sat, 18 Nov 2023 16:23:46 -0800 [thread overview]
Message-ID: <20231118162346.0c66226a@kernel.org> (raw)
In-Reply-To: <20231118062754.2453-4-quic_luoj@quicinc.com>
On Sat, 18 Nov 2023 14:27:51 +0800 Luo Jie wrote:
> + /* There are two PCSs available for QCA8084, which support the following
> + * interface modes.
> + *
> + * 1. PHY_INTERFACE_MODE_10G_QXGMII utilizes PCS1 for all available 4 ports,
> + * which is for all link speeds.
> + *
> + * 2. PHY_INTERFACE_MODE_2500BASEX utilizes PCS0 for the fourth port,
> + * which is only for the link speed 2500M same as QCA8081.
> + *
> + * 3. PHY_INTERFACE_MODE_SGMII utilizes PCS0 for the fourth port,
> + * which is for the link speed 10M, 100M and 1000M same as QCA8081.
Wrap the comments please.
Please use checkpatch with --max-line-length=80
next prev parent reply other threads:[~2023-11-19 0:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 6:27 [PATCH v5 0/6] add qca8084 ethernet phy driver Luo Jie
2023-11-18 6:27 ` [PATCH v5 1/6] net: phy: introduce core support for phy-mode = "10g-qxgmii" Luo Jie
2023-11-18 6:27 ` [PATCH v5 2/6] dt-bindings: net: ethernet-controller: add 10g-qxgmii mode Luo Jie
2023-11-18 6:27 ` [PATCH v5 3/6] net: phy: at803x: add QCA8084 ethernet phy support Luo Jie
2023-11-18 15:51 ` Andrew Lunn
2023-11-18 19:33 ` Russell King (Oracle)
2023-11-18 20:19 ` Andrew Lunn
2023-11-20 8:49 ` Jie Luo
2023-11-20 9:29 ` Russell King (Oracle)
2023-11-21 11:01 ` Jie Luo
2023-11-20 15:34 ` Andrew Lunn
2023-11-20 16:18 ` Russell King (Oracle)
2023-11-21 11:15 ` Jie Luo
2023-11-21 11:10 ` Jie Luo
2023-11-21 11:52 ` Russell King (Oracle)
2023-11-23 10:57 ` Jie Luo
2023-11-23 12:01 ` Russell King (Oracle)
2023-11-24 9:47 ` Jie Luo
2023-11-24 9:53 ` Russell King (Oracle)
2023-11-24 10:41 ` Jie Luo
2023-11-19 0:23 ` Jakub Kicinski [this message]
2023-11-20 8:55 ` Jie Luo
2023-11-18 6:27 ` [PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is_qca808x Luo Jie
2023-11-19 0:22 ` Jakub Kicinski
2023-11-20 8:56 ` Jie Luo
2023-11-18 6:27 ` [PATCH v5 5/6] net: phy: at803x: Add qca8084_config_init function Luo Jie
2023-11-18 6:27 ` [PATCH v5 6/6] net: phy: qca8084: add qca8084_link_change_notify Luo Jie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231118162346.0c66226a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_luoj@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).