From: Conor Dooley <conor@kernel.org>
To: Elad Nachman <enachman@marvell.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com,
sebastian.hesselbarth@gmail.com, pali@kernel.org,
mrkiko.rs@gmail.com, chris.packham@alliedtelesis.co.nz,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, cyuval@marvell.com
Subject: Re: [PATCH v5 2/3] dt-bindings: arm64: add Marvell COM Express boards
Date: Sun, 19 Nov 2023 13:34:35 +0000 [thread overview]
Message-ID: <20231119-avatar-implicate-75cd2f12dff5@spud> (raw)
In-Reply-To: <20231119102638.1041978-3-enachman@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 1688 bytes --]
On Sun, Nov 19, 2023 at 12:26:37PM +0200, Elad Nachman wrote:
> From: Elad Nachman <enachman@marvell.com>
>
> Add dt bindings for:
> CN9130 COM Express CPU module
Did you forget this one? There's only the CN9191 system here.
> CN9131 COM Express CPU module
> AC5X RD COM Express Type 7 carrier board.
> AC5X RD COM Express board with a CN9131 COM Express Type 7 CPU module.
>
> Signed-off-by: Elad Nachman <enachman@marvell.com>
> ---
> .../bindings/arm/marvell/armada-7k-8k.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> index 52d78521e412..6b19f23bcf63 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> @@ -60,4 +60,16 @@ properties:
> - const: marvell,armada-ap807-quad
> - const: marvell,armada-ap807
>
> + - description:
> + Alleycat5X (98DX35xx) Reference Design as COM Express Carrier plus
> + Armada CN9131 COM Express CPU module
> + items:
> + - enum:
> + - marvell,ac5x-car-with-cn9131
Why not just marvell,cn9131-ac5x-carrier or similar? The "with" isn't
particularly helpful.
Cheers,
Conor.
> + - const: marvell,rd-ac5x-carrier
> + - const: marvell,cn9131-cpu-module
> + - const: marvell,cn9131
> + - const: marvell,armada-ap807-quad
> + - const: marvell,armada-ap807
> +
> additionalProperties: true
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-11-19 13:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-19 10:26 [PATCH v5 0/3] arm64: dts: cn913x: add COM Express boards Elad Nachman
2023-11-19 10:26 ` [PATCH v5 1/3] MAINTAINERS: add ac5 to list of maintained Marvell dts files Elad Nachman
2023-11-19 16:32 ` Andrew Lunn
2023-11-19 10:26 ` [PATCH v5 2/3] dt-bindings: arm64: add Marvell COM Express boards Elad Nachman
2023-11-19 13:34 ` Conor Dooley [this message]
2023-11-19 16:30 ` Andrew Lunn
2023-11-19 13:43 ` Rob Herring
2023-11-20 9:08 ` kernel test robot
2023-11-19 10:26 ` [PATCH v5 3/3] arm64: dts: cn913x: add device trees for " Elad Nachman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231119-avatar-implicate-75cd2f12dff5@spud \
--to=conor@kernel.org \
--cc=andrew@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=cyuval@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=enachman@marvell.com \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mrkiko.rs@gmail.com \
--cc=pali@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).