From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41537134BA; Sun, 19 Nov 2023 15:08:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VNTtecu+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A71FC433C7; Sun, 19 Nov 2023 15:08:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700406489; bh=DaOvlUbm/d5dvcv4fwobRa+i+wZixsmjZoJS2PIC9AA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VNTtecu+LhBFOjoSX1gBMP+tbB6apLHBbBKWlvPq9Py3qanifjqE3OLX12lWH+9aN vznns/BAk+RKkNuHR+Gr7f0SX/5at/ixS3cOGxMadfSq4uIr6DbO5pp8wWMLqxXMRb Fde2og3EoUD8tX9moHehS0/o5yfmSgzlL6apfXx+DY66+yEPGXgILZIkC3NPLZgpAm 0ABTrcRjkPHLXJUQzJtimhmY5EENUnO6g3Dg7mzkYNIW0hcOjFp08KYqAYok1XxWiE g5hgEWkm+BbmtB2FsS6UUteVCpAKFXaHzxhoZOldmj5/1MQ5s2cU+5yJNEUQ/vX950 ZaN0dTD3LIPZQ== Date: Sun, 19 Nov 2023 15:07:56 +0000 From: Jonathan Cameron To: Marek Vasut Cc: linux-iio@vger.kernel.org, Conor Dooley , Alexander Stein , Andre Werner , Andy Shevchenko , Bjorn Helgaas , Conor Dooley , Fabio Estevam , Guenter Roeck , Krzysztof Kozlowski , Lars-Peter Clausen , Luca Ceresoli , Mark Brown , Matti Vaittinen , Naresh Solanki , Patrick Rudolph , Rob Herring , Stefan Windfeldt-Prytz , Vincent Tremblay , devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: iio: light: isl76682: Document ISL76682 Message-ID: <20231119150756.20a023b5@jic23-huawei> In-Reply-To: <20231118000614.186558-1-marex@denx.de> References: <20231118000614.186558-1-marex@denx.de> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 18 Nov 2023 01:06:09 +0100 Marek Vasut wrote: > The ISL76682 is very basic ALS which only supports ALS or IR mode > in four ranges, 1k/4k/16k/64k LUX. There is no IRQ support or any > other fancy functionality. Document it as trivial device. > > Acked-by: Conor Dooley > Signed-off-by: Marek Vasut I'm always a bit in 2 minds about trivial-devices as it doesn't include a basic power supply. In this case vdd which I'd prefer to see documented even on such a simple device as this. Not everyone is going to leave it powered up all the time! Still I'm not that fussed. Maybe it's worth allowing vdd-supply in trivial-devices.yaml? Jonathan > --- > Cc: Alexander Stein > Cc: Andre Werner > Cc: Andy Shevchenko > Cc: Bjorn Helgaas > Cc: Conor Dooley > Cc: Fabio Estevam > Cc: Guenter Roeck > Cc: Jonathan Cameron > Cc: Krzysztof Kozlowski > Cc: Lars-Peter Clausen > Cc: Luca Ceresoli > Cc: Mark Brown > Cc: Matti Vaittinen > Cc: Naresh Solanki > Cc: Patrick Rudolph > Cc: Rob Herring > Cc: Stefan Windfeldt-Prytz > Cc: Vincent Tremblay > Cc: devicetree@vger.kernel.org > Cc: linux-iio@vger.kernel.org > --- > V2: Add AB from Conor > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index c3190f2a168a2..27164e9219276 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -179,6 +179,8 @@ properties: > - isil,isl29030 > # Intersil ISL68137 Digital Output Configurable PWM Controller > - isil,isl68137 > + # Intersil ISL76682 Ambient Light Sensor > + - isil,isl76682 > # Linear Technology LTC2488 > - lineartechnology,ltc2488 > # 5 Bit Programmable, Pulse-Width Modulator