From: Christian Marangi <ansuelsmth@gmail.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Daniel Golle <daniel@makrotopia.org>,
Qingfang Deng <dqfext@gmail.com>,
SkyLake Huang <SkyLake.Huang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
David Epping <david.epping@missinglinkelectronics.com>,
Vladimir Oltean <olteanv@gmail.com>,
Christian Marangi <ansuelsmth@gmail.com>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Harini Katakam <harini.katakam@amd.com>,
Simon Horman <horms@kernel.org>,
Robert Marko <robert.marko@sartura.hr>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: [net-next RFC PATCH 05/14] net: phy: add support for named global PHY in DT PHY package
Date: Mon, 20 Nov 2023 14:50:32 +0100 [thread overview]
Message-ID: <20231120135041.15259-6-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20231120135041.15259-1-ansuelsmth@gmail.com>
Add support for named global PHY in DT PHY package definition.
A phy-package node can provide the property "global-phy-names" to
provide named global PHY to correctly reference the phandle defined in
the global-phys list.
Each PHY driver has to define the .phy_package_global_phy_names list
to verify correct order of named PHY phandle defined in DT with the
expected order in the PHY driver.
If the list is not defined or "global-phy-names" is not defined in
DT, global phy addresses are insered in order defined in the "global-phys"
property.
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
drivers/net/phy/phy_device.c | 13 +++++++++++++
include/linux/phy.h | 6 +++++-
2 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 9ff76d84dca0..452fd69e8924 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -3198,6 +3198,7 @@ static int of_phy_package(struct phy_device *phydev)
struct device_node *node = phydev->mdio.dev.of_node;
struct of_phandle_args phy_phandle;
struct device_node *package_node;
+ const char *global_phy_name;
int i, global_phys_num, ret;
int *global_phy_addrs;
@@ -3236,6 +3237,18 @@ static int of_phy_package(struct phy_device *phydev)
if (ret)
goto exit;
+ ret = of_property_read_string_index(package_node, "global-phy-names",
+ i, &global_phy_name);
+ if (!ret && phydev->drv->phy_package_global_phy_names) {
+ const char *name;
+
+ name = phydev->drv->phy_package_global_phy_names[i];
+ if (strcmp(global_phy_name, name)) {
+ ret = -EINVAL;
+ goto exit;
+ }
+ }
+
global_phy_addrs[i] = addr;
}
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 5bf90c49e5bd..5e595a0a43b6 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -892,6 +892,10 @@ struct phy_led {
* @driver_data: Static driver data
* @phy_package_global_phy_num: Num of the required global phy
* for PHY package global configuration.
+ * @phy_package_global_phy_names: List of global PHY names used
+ * for PHY package global init. If defined, list is compared
+ * with DT values to match correct PHY phandle order. List
+ * last element MUST BE an empty string.
*
* All functions are optional. If config_aneg or read_status
* are not implemented, the phy core uses the genphy versions.
@@ -910,6 +914,7 @@ struct phy_driver {
u32 flags;
const void *driver_data;
unsigned int phy_package_global_phy_num;
+ const char * const *phy_package_global_phy_names;
/**
* @soft_reset: Called to issue a PHY software reset
@@ -1154,7 +1159,6 @@ struct phy_driver {
*/
int (*led_hw_control_get)(struct phy_device *dev, u8 index,
unsigned long *rules);
-
};
#define to_phy_driver(d) container_of(to_mdio_common_driver(d), \
struct phy_driver, mdiodrv)
--
2.40.1
next prev parent reply other threads:[~2023-11-20 13:51 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 13:50 [net-next RFC PATCH 00/14] net: phy: Support DT PHY package Christian Marangi
2023-11-20 13:50 ` [net-next RFC PATCH 01/14] net: phy: extend PHY package API to support multiple global address Christian Marangi
2023-11-20 13:50 ` [net-next RFC PATCH 02/14] dt-bindings: net: move PHY modes to common PHY mode types definition Christian Marangi
2023-11-20 15:14 ` Rob Herring
2023-11-20 17:30 ` Rob Herring
2023-11-20 13:50 ` [net-next RFC PATCH 03/14] dt-bindings: net: document ethernet PHY package nodes Christian Marangi
2023-11-20 17:41 ` Rob Herring
2023-11-20 16:39 ` Christian Marangi
2023-11-20 20:44 ` Andrew Lunn
2023-11-20 18:09 ` Christian Marangi
2023-11-20 21:25 ` Andrew Lunn
2023-11-20 18:45 ` Christian Marangi
2023-11-21 14:42 ` Rob Herring
2023-11-21 14:45 ` Andrew Lunn
2023-11-22 18:32 ` Christian Marangi
2023-11-23 3:30 ` Andrew Lunn
2023-11-23 10:38 ` Christian Marangi
2023-11-23 14:27 ` Andrew Lunn
2023-11-23 14:35 ` Russell King (Oracle)
2023-11-23 14:57 ` Andrew Lunn
2023-11-23 19:33 ` Christian Marangi
2023-11-24 11:49 ` Jie Luo
2023-11-24 12:02 ` Russell King (Oracle)
2023-11-24 14:44 ` Andrew Lunn
2023-11-24 15:16 ` Russell King (Oracle)
2023-11-24 16:59 ` Robert Marko
2023-11-23 15:07 ` Andrew Lunn
2023-11-23 19:36 ` Christian Marangi
2023-11-24 16:59 ` Vladimir Oltean
2023-11-24 16:25 ` Christian Marangi
2023-11-24 18:27 ` Vladimir Oltean
2023-11-24 18:35 ` Andrew Lunn
2023-11-24 19:40 ` Vladimir Oltean
2023-11-20 13:50 ` [net-next RFC PATCH 04/14] net: phy: add initial support for PHY package in DT Christian Marangi
2023-11-22 10:41 ` Simon Horman
2023-11-22 10:52 ` Simon Horman
2023-11-22 18:15 ` Christian Marangi
2023-11-22 21:14 ` Simon Horman
2023-11-20 13:50 ` Christian Marangi [this message]
2023-11-20 13:50 ` [net-next RFC PATCH 06/14] net: phy: add support for shared priv data size " Christian Marangi
2023-11-20 13:50 ` [net-next RFC PATCH 07/14] net: phy: add support for driver specific PHY package probe/config Christian Marangi
2023-11-20 13:50 ` [net-next RFC PATCH 08/14] net: phy: add support for PHY package interface mode Christian Marangi
2023-11-20 13:50 ` [net-next RFC PATCH 09/14] net: phy: move mmd_phy_indirect to generic header Christian Marangi
2023-11-20 13:50 ` [net-next RFC PATCH 10/14] net: phy: add support for PHY package MMD read/write Christian Marangi
2023-11-20 13:50 ` [net-next RFC PATCH 11/14] dt-bindings: net: add QCA807x PHY defines Christian Marangi
2023-11-23 3:01 ` Andrew Lunn
2023-11-20 13:50 ` [net-next RFC PATCH 12/14] dt-bindings: net: Document Qcom QCA807x PHY package Christian Marangi
2023-11-23 2:15 ` Andrew Lunn
2023-11-23 11:20 ` Robert Marko
2023-11-23 9:41 ` Russell King (Oracle)
2023-11-20 13:50 ` [net-next RFC PATCH 13/14] net: phy: add Qualcom QCA807x driver Christian Marangi
2023-11-23 2:55 ` Andrew Lunn
2023-11-20 13:50 ` [net-next RFC PATCH 14/14] net: phy: qca807x: Add support for configurable LED Christian Marangi
2023-11-20 15:11 ` [net-next RFC PATCH 00/14] net: phy: Support DT PHY package Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231120135041.15259-6-ansuelsmth@gmail.com \
--to=ansuelsmth@gmail.com \
--cc=SkyLake.Huang@mediatek.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=david.epping@missinglinkelectronics.com \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=harini.katakam@amd.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).